hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ramkrishna.s.vasudevan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-13510) Refactor Bloom filters to make use of Cell Comparators in case of ROW_COL
Date Wed, 06 May 2015 10:06:00 GMT

    [ https://issues.apache.org/jira/browse/HBASE-13510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14530286#comment-14530286
] 

ramkrishna.s.vasudevan commented on HBASE-13510:
------------------------------------------------

bq.The CompoundBloomFilterWriter uses ByteBloomFilter chunk and its state. Can we move these
states to CompoundBloomFilter or so? There are some static methods in ByteBloomFilter which
is used from other places, that also we can move into other appropriate places. 
In this patch still ByteBloomFilter is a BloomFilterWriter. My thinking is we can avoid that
also.
I had a patch where all the static were moved to BloomfilterUtils.  But I think it was suggested
that will make the patch bigger.  So the chunk that we create as a ByteBloomfilter should
direclty be a BloomFilterWriter and we should call it BloomFilterWriterImpl

> Refactor Bloom filters to make use of Cell Comparators in case of ROW_COL
> -------------------------------------------------------------------------
>
>                 Key: HBASE-13510
>                 URL: https://issues.apache.org/jira/browse/HBASE-13510
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: ramkrishna.s.vasudevan
>             Fix For: 2.0.0
>
>         Attachments: HBASE-13510_1.patch
>
>
> In order to address the comments over in HBASE-10800 related to comparing Cell with a
serialized KV's key we had some need for that in Bloom filters.  After discussing with Anoop,
we found that it may be possible to remove/modify some of the APIs in the BloomFilter interfaces
and for doing that we can purge ByteBloomFilter.  
> I read the code and found that ByteBloomFilter was getting used in V1 version only. 
Now as it is obsolete we can remove this code and move some of the static APIs in ByteBloomFilter
to some other util class or bloom related classes which will help us in refactoring the code
too.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message