hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anoop Sam John (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-13448) New Cell implementation with cached component offsets/lengths
Date Sat, 23 May 2015 06:54:17 GMT

    [ https://issues.apache.org/jira/browse/HBASE-13448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14557179#comment-14557179
] 

Anoop Sam John commented on HBASE-13448:
----------------------------------------

One thing to note regarding the number of calls to getXXXLengths() is that I have done it
on case where cells are returned. Some calls might be happening after the FIlter#filterKeyValue().
 So when we test with filter all which filters cells with call to Filter#filterKeyValue(Cell),
 we might not be hitting the same getXXXLength() calls those many times.
Done the above PE tests. The gain is not so much still with patch is better than trunk always

 With patch
 20 client threads
 Summary of timings (ms): [15351, 15122, 14875, 14566, 14932, 14952, 15268, 15141, 15352,
14669, 15043, 15283, 15252, 15284, 15283, 15321, 14733, 15320, 15278, 15096]
2015-05-23 17:38:49,666 INFO  [main] hbase.PerformanceEvaluation: [RandomScanWithRange10000Test]
       Min: 14566ms    Max: 15352ms    Avg: 15106ms
Summary of timings (ms): [15185, 14333, 14863, 15320, 15247, 15278, 14982, 14772, 14918, 15234,
15189, 14999, 15107, 14987, 15090, 14614, 15328, 14428, 15281, 14490]
2015-05-23 17:39:39,884 INFO  [main] hbase.PerformanceEvaluation: [RandomScanWithRange10000Test]
       Min: 14333ms    Max: 15328ms    Avg: 14982ms
Summary of timings (ms): [14857, 15142, 14675, 14902, 15174, 15073, 14981, 14942, 14572, 14594,
14771, 15259, 14446, 15037, 14947, 15250, 15059, 14502, 15026, 15073]
2015-05-23 17:40:43,636 INFO  [main] hbase.PerformanceEvaluation: [RandomScanWithRange10000Test]
       Min: 14446ms    Max: 15259ms    Avg: 14914ms
Summary of timings (ms): [14970, 15299, 15147, 15307, 15141, 14736, 14972, 14960, 14417, 15140,
15276, 15055, 14724, 15275, 14642, 14633, 15106, 14945, 14767, 15297]
2015-05-23 17:41:11,239 INFO  [main] hbase.PerformanceEvaluation: [RandomScanWithRange10000Test]
       Min: 14417ms    Max: 15307ms    Avg: 14990ms
Summary of timings (ms): [14695, 15084, 14805, 15445, 15437, 15327, 15453, 15303, 15053, 15454,
14881, 14897, 14835, 15418, 15059, 15585, 15013, 14754, 15320, 15224]
2015-05-23 17:41:48,880 INFO  [main] hbase.PerformanceEvaluation: [RandomScanWithRange10000Test]
       Min: 14695ms    Max: 15585ms    Avg: 15152ms

1 client thread
7857ms
8115ms
7994ms
8149ms
7925ms
8051ms
8005ms
8083ms


trunk
20 client threads
Summary of timings (ms): [15467, 15586, 15760, 15182, 14795, 15453, 15113, 15233, 14966, 14552,
15204, 15466, 14693, 15030, 15497, 15526, 15451, 15356, 15499, 15029]
2015-05-23 17:52:28,914 INFO  [main] hbase.PerformanceEvaluation: [RandomScanWithRange10000Test]
       Min: 14552ms    Max: 15760ms    Avg: 15242ms
 Summary of timings (ms): [15474, 15386, 14969, 15165, 15339, 15278, 14507, 15190, 15159,
14933, 15235, 15214, 14713, 15288, 15386, 15464, 15358, 15364, 15495, 15171]
2015-05-23 17:52:58,467 INFO  [main] hbase.PerformanceEvaluation: [RandomScanWithRange10000Test]
       Min: 14507ms    Max: 15495ms    Avg: 15204ms
 Summary of timings (ms): [15251, 15021, 15065, 15054, 14876, 14892, 14867, 14983, 15083,
14788, 14989, 14761, 14694, 14454, 14426, 14769, 14729, 14764, 14977, 14271]
2015-05-23 17:53:58,776 INFO  [main] hbase.PerformanceEvaluation: [RandomScanWithRange10000Test]
       Min: 14271ms    Max: 15251ms    Avg: 14835ms
 Summary of timings (ms): [15446, 14696, 15315, 14483, 15216, 15172, 15504, 15141, 15369,
15479, 15474, 15307, 15229, 15411, 14944, 15233, 15481, 15469, 14951, 15382]
2015-05-23 17:54:44,327 INFO  [main] hbase.PerformanceEvaluation: [RandomScanWithRange10000Test]
       Min: 14483ms    Max: 15504ms    Avg: 15235ms
 Summary of timings (ms): [15311, 15658, 15125, 14855, 15152, 15553, 15187, 14918, 15403,
15331, 15061, 15483, 15455, 15354, 15273, 15002, 15514, 14761, 15281, 15198]
2015-05-23 17:57:18,229 INFO  [main] hbase.PerformanceEvaluation: [RandomScanWithRange10000Test]
       Min: 14761ms    Max: 15658ms    Avg: 15243ms

1 client thread
8170ms
8064ms
8191ms
8150ms
8143ms
8307ms
8215ms
8281ms



> New Cell implementation with cached component offsets/lengths
> -------------------------------------------------------------
>
>                 Key: HBASE-13448
>                 URL: https://issues.apache.org/jira/browse/HBASE-13448
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Scanners
>            Reporter: Anoop Sam John
>            Assignee: Anoop Sam John
>             Fix For: 2.0.0
>
>         Attachments: 13448-0.98.txt, HBASE-13448.patch, HBASE-13448_V2.patch, HBASE-13448_V3.patch,
gc.png, hits.png
>
>
> This can be extension to KeyValue and can be instantiated and used in read path.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message