hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mikhail Antonov (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-13375) Provide HBase superuser higher priority over other users in the RPC handling
Date Wed, 20 May 2015 10:17:00 GMT

    [ https://issues.apache.org/jira/browse/HBASE-13375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14552093#comment-14552093
] 

Mikhail Antonov commented on HBASE-13375:
-----------------------------------------

Speaking of the proper place for these 2 methods - I would agree that they may not be totally
coherent with the User class scope, but, from practical standpoint, I'm not sure I see any
apparently better way. These method were moved here from AccessConstorlLists class, which
is in hbase-server module and isn't accessible from places like hbase-common. I'm somewhat
reluctant to create new AuthenticationUtil class just to put there 2 one-liner methods (also
- getGroupName() for example is basically producing a substring of another string - that's
not really "authentication" functionality).

Speaking of the Jira at more high level - this one started as optimization RPC priority handling,
then is was found that the way we retrieve list of super user isn't the best one (VisibilityUtils
it was originally), and then in HBASE-10619 it was pointed out that we have 4 or 5 places
where we parse and cache this information and it'd be better to reimplement it to keep this
information in one place (User class was proposed). So I did these changes here, and I think
HBASE-10619 is now blocked (?) waiting for changes in that part of API.

So I'm thinking maybe we could move on with the implementation in latest patch to this jira,
that would also unblock HBASE-10619, and open another jira if needed to discuss whether we
should create AuthenticationUtil class, and if yes, should it be a singleton or not etc?

> Provide HBase superuser higher priority over other users in the RPC handling
> ----------------------------------------------------------------------------
>
>                 Key: HBASE-13375
>                 URL: https://issues.apache.org/jira/browse/HBASE-13375
>             Project: HBase
>          Issue Type: Improvement
>          Components: rpc
>            Reporter: Devaraj Das
>            Assignee: Mikhail Antonov
>             Fix For: 1.1.1
>
>         Attachments: HBASE-13375-v0.patch, HBASE-13375-v1.patch, HBASE-13375-v1.patch,
HBASE-13375-v1.patch, HBASE-13375-v2.patch, HBASE-13375-v3.patch, HBASE-13375-v4.patch, HBASE-13375-v5.patch,
HBASE-13375-v6.patch, HBASE-13375-v7.patch
>
>
> HBASE-13351 annotates Master RPCs so that RegionServer RPCs are treated with a higher
priority compared to user RPCs (and they are handled by a separate set of handlers, etc.).
It may be good to stretch this to users too - hbase superuser (configured via hbase.superuser)
gets higher priority over other users in the RPC handling. That way the superuser can always
perform administrative operations on the cluster even if all the normal priority handlers
are occupied (for example, we had a situation where all the master's handlers were tied up
with many simultaneous createTable RPC calls from multiple users and the master wasn't able
to perform any operations initiated by the admin). (Discussed this some with [~enis] and [~elserj]).
> Does this make sense to others?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message