hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Josh Elser (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-13375) Provide HBase superuser higher priority over other users in the RPC handling
Date Wed, 20 May 2015 04:43:59 GMT

    [ https://issues.apache.org/jira/browse/HBASE-13375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14551803#comment-14551803
] 

Josh Elser commented on HBASE-13375:
------------------------------------

LGTM (non-binding), I'd say. One nit jumped out at me

{code}
+  public boolean isSuperUser()
+    throws IOException {
+    if (superUsers == null || superGroups == null) {
+      throw new IOException("Super users/super groups lists haven't been initialized properly,");
+    }
{code}

We're not doing any IO here, so an IOException is a little weird to throw. Not a huge issue
(given how often IOException gets misused anyways).

> Provide HBase superuser higher priority over other users in the RPC handling
> ----------------------------------------------------------------------------
>
>                 Key: HBASE-13375
>                 URL: https://issues.apache.org/jira/browse/HBASE-13375
>             Project: HBase
>          Issue Type: Improvement
>          Components: rpc
>            Reporter: Devaraj Das
>            Assignee: Mikhail Antonov
>             Fix For: 1.1.1
>
>         Attachments: HBASE-13375-v0.patch, HBASE-13375-v1.patch, HBASE-13375-v1.patch,
HBASE-13375-v1.patch, HBASE-13375-v2.patch, HBASE-13375-v3.patch, HBASE-13375-v4.patch, HBASE-13375-v5.patch,
HBASE-13375-v6.patch, HBASE-13375-v7.patch
>
>
> HBASE-13351 annotates Master RPCs so that RegionServer RPCs are treated with a higher
priority compared to user RPCs (and they are handled by a separate set of handlers, etc.).
It may be good to stretch this to users too - hbase superuser (configured via hbase.superuser)
gets higher priority over other users in the RPC handling. That way the superuser can always
perform administrative operations on the cluster even if all the normal priority handlers
are occupied (for example, we had a situation where all the master's handlers were tied up
with many simultaneous createTable RPC calls from multiple users and the master wasn't able
to perform any operations initiated by the admin). (Discussed this some with [~enis] and [~elserj]).
> Does this make sense to others?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message