hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-13368) Hash.java is declared as public Interface - but it should be Private
Date Wed, 06 May 2015 14:43:00 GMT

    [ https://issues.apache.org/jira/browse/HBASE-13368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14530645#comment-14530645
] 

Hudson commented on HBASE-13368:
--------------------------------

FAILURE: Integrated in HBase-0.98-on-Hadoop-1.1 #932 (See [https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/932/])
HBASE-13632 -  Backport HBASE-13368 to branch-1 and 0.98 (Ram) (ramkrishna: rev 38cd559456aa93128743e02a00922f4cf3e95f95)
* hbase-common/src/main/java/org/apache/hadoop/hbase/util/JenkinsHash.java
* hbase-common/src/main/java/org/apache/hadoop/hbase/util/MurmurHash.java
* hbase-common/src/main/java/org/apache/hadoop/hbase/util/Hash.java
* hbase-common/src/main/java/org/apache/hadoop/hbase/util/MurmurHash3.java


> Hash.java is declared as public Interface - but it should be Private
> --------------------------------------------------------------------
>
>                 Key: HBASE-13368
>                 URL: https://issues.apache.org/jira/browse/HBASE-13368
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 1.0.0, 1.1.0
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: ramkrishna.s.vasudevan
>            Priority: Trivial
>             Fix For: 2.0.0
>
>         Attachments: HBASE-13368.patch, HBASE-13368_1.patch
>
>
> Currently Hash.java is marked as public.  But we are not allowing the user to configure
his own Hash.java impl using FQCN.  It is currently working as an enum based type.  
> So this class should be an Private interface and not a direct user facing interface.
Thanks to Anoop for confirming on this.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message