hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-11927) Use Native Hadoop Library for HFile checksum (And flip default from CRC32 to CRC32C)
Date Fri, 15 May 2015 01:09:00 GMT

    [ https://issues.apache.org/jira/browse/HBASE-11927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14544707#comment-14544707

stack commented on HBASE-11927:

hadoopqa is it [~appy] -- you could get ./dev/test-patch.sh to run locally but might as well
have jenkins do the job for you. There is no shame in a checkstyle or too long a line in a
patch... Just address and resubmit.  For the checkstyle above, look at the report listed in
hadoopqa output: https://builds.apache.org/job/PreCommit-HBASE-Build/14049//artifact/patchprocess/checkstyle-aggregate.html

Looking at files in your patch and what is reported in checkstyle report, these might be yours:



Just fix the unused imports should be enough.

> Use Native Hadoop Library for HFile checksum (And flip default from CRC32 to CRC32C)
> ------------------------------------------------------------------------------------
>                 Key: HBASE-11927
>                 URL: https://issues.apache.org/jira/browse/HBASE-11927
>             Project: HBase
>          Issue Type: Bug
>            Reporter: stack
>            Assignee: Apekshit Sharma
>         Attachments: HBASE-11927-v1.patch, HBASE-11927-v2.patch, HBASE-11927-v4.patch,
HBASE-11927-v5.patch, HBASE-11927-v6.patch, HBASE-11927.patch, after-compact-2%.svg, after-randomWrite1M-0.5%.svg,
before-compact-22%.svg, before-randomWrite1M-5%.svg, c2021.crc2.svg, c2021.write.2.svg, c2021.zip.svg,
> Up in hadoop they have this change. Let me publish some graphs to show that it makes
a difference (CRC is a massive amount of our CPU usage in my profiling of an upload because
of compacting, flushing, etc.).  We should also make use of native CRCings -- especially the
2.6 HDFS-6865 and ilk -- in hbase but that is another issue for now.

This message was sent by Atlassian JIRA

View raw message