hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ramkrishna.s.vasudevan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-10800) Use CellComparator instead of KVComparator
Date Wed, 06 May 2015 04:55:01 GMT

    [ https://issues.apache.org/jira/browse/HBASE-10800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14529919#comment-14529919
] 

ramkrishna.s.vasudevan commented on HBASE-10800:
------------------------------------------------

[~Apache9]
Thanks for pointing out.  Even before this the else should have been a dead code.  We can
just remove that piece of code.
Before patch
See the constructor of BDE
{code}
    public BufferedEncodedSeeker(KVComparator comparator,
        HFileBlockDecodingContext decodingCtx) {
      this.comparator = comparator;
      this.samePrefixComparator = comparator;
      this.decodingCtx = decodingCtx;
{code}
And this piece of code was 
{code}
if (samePrefixComparator != null) {
........
else {
Cell r = new KeyValue.KeyOnlyKeyValue(current.keyBuffer, 0, current.keyLength);
          comp = comparator.compareOnlyKeyPortion(seekCell, r);
}
{code}
Ideally both were same.  In this patch I removed this unnecessary two references.  But forgot
to clear this.  I can given an addendum or raise a new JIRA for the this.

> Use CellComparator instead of KVComparator
> ------------------------------------------
>
>                 Key: HBASE-10800
>                 URL: https://issues.apache.org/jira/browse/HBASE-10800
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: ramkrishna.s.vasudevan
>             Fix For: 2.0.0
>
>         Attachments: HBASE-10800_1.patch, HBASE-10800_11.patch, HBASE-10800_12.patch,
HBASE-10800_13.patch, HBASE-10800_14.patch, HBASE-10800_15.patch, HBASE-10800_16.patch, HBASE-10800_18.patch,
HBASE-10800_2.patch, HBASE-10800_23.patch, HBASE-10800_23.patch, HBASE-10800_24.patch, HBASE-10800_25.patch,
HBASE-10800_26.patch, HBASE-10800_27.patch, HBASE-10800_28.patch, HBASE-10800_29.patch, HBASE-10800_3.patch,
HBASE-10800_4.patch, HBASE-10800_4.patch, HBASE-10800_5.patch, HBASE-10800_6.patch, HBASE-10800_7.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message