hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-8927) Use nano time instead of mili time everywhere
Date Fri, 15 May 2015 03:00:03 GMT

    [ https://issues.apache.org/jira/browse/HBASE-8927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14544833#comment-14544833
] 

Hadoop QA commented on HBASE-8927:
----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12733022/8927-WIP-TEST.txt
  against master branch at commit 9ba7337ac82d13b22a1b0c40edaba7873c0bd795.
  ATTACHMENT ID: 12733022

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 hadoop versions{color}. The patch compiles with all supported hadoop versions
(2.4.1 2.5.2 2.6.0)

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 protoc{color}.  The applied patch does not increase the total number of
protoc compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

                {color:red}-1 checkstyle{color}.  The applied patch generated 1901 checkstyle
errors (more than the master's current 1898 errors).

    {color:green}+1 findbugs{color}.  The patch does not introduce any  new Findbugs (version
2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines longer than
100:
    +      LOG.warn("\""+TIMESTAMP_RESOLUTION+"\" parameter cannot be updated! Ignore.", new
Exception());
+  private static long determineTTLFromFamily(final HColumnDescriptor family, final HTableDescriptor
table) {
+        htd.setTimestampResolution(JInteger.valueOf(arg.delete(TIMESTAMP_RESOLUTION))) if
arg[TIMESTAMP_RESOLUTION]

  {color:green}+1 site{color}.  The mvn site goal succeeds with this patch.

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
                       org.apache.hadoop.hbase.regionserver.TestDefaultMemStore
                  org.apache.hadoop.hbase.regionserver.TestReversibleScanners
                  org.apache.hadoop.hbase.regionserver.TestStoreScanner

     {color:red}-1 core zombie tests{color}.  There are 2 zombie test(s): 	at org.apache.hadoop.hbase.ResourceCheckerJUnitListener.testFinished(ResourceCheckerJUnitListener.java:183)
	at org.apache.hadoop.hbase.io.hfile.TestScannerSelectionUsingTTL.testScannerSelection(TestScannerSelectionUsingTTL.java:116)

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/14052//testReport/
Release Findbugs (version 2.0.3) 	warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/14052//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/14052//artifact/patchprocess/checkstyle-aggregate.html

                Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/14052//console

This message is automatically generated.

> Use nano time instead of mili time everywhere
> ---------------------------------------------
>
>                 Key: HBASE-8927
>                 URL: https://issues.apache.org/jira/browse/HBASE-8927
>             Project: HBase
>          Issue Type: Bug
>            Reporter: stack
>              Labels: phoenix
>         Attachments: 8927-WIP-TEST.txt, 8927.txt
>
>
> Less collisions and we are paying the price of a long anyways so might as well fill it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message