Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 4EED618AE9 for ; Mon, 27 Apr 2015 06:28:39 +0000 (UTC) Received: (qmail 19228 invoked by uid 500); 27 Apr 2015 06:28:39 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 19169 invoked by uid 500); 27 Apr 2015 06:28:39 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 19157 invoked by uid 99); 27 Apr 2015 06:28:39 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 27 Apr 2015 06:28:39 +0000 Date: Mon, 27 Apr 2015 06:28:39 +0000 (UTC) From: "Enis Soztutar (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-13568) Make Waiter class a public API. MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-13568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14513604#comment-14513604 ] Enis Soztutar commented on HBASE-13568: --------------------------------------- I guess you were mentioning my review comment. I was implying that we can re-use Waiter that we have already in the proc code. The intention was not to make it a public class, but merely moving from tests to main thus making it useable internally. I don't think we should make Waiter a public API. > Make Waiter class a public API. > ------------------------------- > > Key: HBASE-13568 > URL: https://issues.apache.org/jira/browse/HBASE-13568 > Project: HBase > Issue Type: Task > Reporter: Srikanth Srungarapu > Assignee: Srikanth Srungarapu > Priority: Minor > Attachments: HBASE-13568.patch, HBASE-13568_v2.patch > > > During ProcV2 code reviews, it is suggested that Waiter class is useful enough to make it a public API. This change decomposes the existing Waiter class into two classes, one for public use and the other exclusively for the internal testing. -- This message was sent by Atlassian JIRA (v6.3.4#6332)