Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 91E4C17D2C for ; Wed, 22 Apr 2015 15:23:59 +0000 (UTC) Received: (qmail 74561 invoked by uid 500); 22 Apr 2015 15:23:59 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 74523 invoked by uid 500); 22 Apr 2015 15:23:59 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 74512 invoked by uid 99); 22 Apr 2015 15:23:59 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 22 Apr 2015 15:23:59 +0000 Date: Wed, 22 Apr 2015 15:23:59 +0000 (UTC) From: "Anoop Sam John (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (HBASE-13496) Make Bytes$LexicographicalComparerHolder$UnsafeComparer::compareTo inlineable MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-13496?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anoop Sam John updated HBASE-13496: ----------------------------------- Attachment: HBASE-13496.patch > Make Bytes$LexicographicalComparerHolder$UnsafeComparer::compareTo inlineable > ----------------------------------------------------------------------------- > > Key: HBASE-13496 > URL: https://issues.apache.org/jira/browse/HBASE-13496 > Project: HBase > Issue Type: Sub-task > Components: Scanners > Reporter: Anoop Sam John > Assignee: Anoop Sam John > Fix For: 2.0.0, 1.2.0 > > Attachments: ByteBufferUtils.java, HBASE-13496.patch, HBASE-13496.patch, OffheapVsOnHeapCompareTest.java, onheapoffheapcompare.tgz > > > While testing with some other perf comparisons I have noticed that the above method (which is very hot in read path) is not getting inline > bq.@ 16 org.apache.hadoop.hbase.util.Bytes$LexicographicalComparerHolder$UnsafeComparer::compareTo (364 bytes) hot method too big > We can do minor refactoring to make it inlineable. -- This message was sent by Atlassian JIRA (v6.3.4#6332)