Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Tue, 21 Apr 2015 06:24:59 +0000 (UTC)
From: "Anoop Sam John (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.12822092.1429378885000.58313.1429597499352@Atlassian.JIRA>
In-Reply-To: <JIRA.12822092.1429378885000@Atlassian.JIRA>
References: <JIRA.12822092.1429378885000@Atlassian.JIRA>
 <JIRA.12822092.1429378885750@arcas>
Subject: [jira] [Commented] (HBASE-13496) Make
 Bytes$LexicographicalComparerHolder$UnsafeComparer::compareTo inlineable
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HBASE-13496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14504427#comment-14504427 ] 

Anoop Sam John commented on HBASE-13496:
----------------------------------------

Stack
I am using jre1.8.0_45.

I was playing with some other compare tests and noticed the Bytes Unsafe based compare is performing lower than an Unsafe comparator we wrote to work with BBs. (Over in HBASE-11425) and then observer that with default settings the inline in not happening.  With a small change it is happening for def setting.
Vladimir
Yes with the change in inlineSize, we can make the bigger methods to get inlined (tested also)  I was saying with the default case. Or else we will have to change our script to pass some bigger max inline size while starting the RS process.  Similar inline optimization is done in this Jiras siblings.

> Make Bytes$LexicographicalComparerHolder$UnsafeComparer::compareTo inlineable
> -----------------------------------------------------------------------------
>
>                 Key: HBASE-13496
>                 URL: https://issues.apache.org/jira/browse/HBASE-13496
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Scanners
>            Reporter: Anoop Sam John
>            Assignee: Anoop Sam John
>             Fix For: 2.0.0, 1.2.0
>
>
> While testing with some other perf comparisons I have noticed that the above method (which is very hot in read path) is not getting inline
> bq.@ 16   org.apache.hadoop.hbase.util.Bytes$LexicographicalComparerHolder$UnsafeComparer::compareTo (364 bytes)   hot method too big
> We can do minor refactoring to make it inlineable.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)