Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id B97811738F for ; Wed, 22 Apr 2015 19:41:59 +0000 (UTC) Received: (qmail 34226 invoked by uid 500); 22 Apr 2015 19:41:59 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 34184 invoked by uid 500); 22 Apr 2015 19:41:59 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 34172 invoked by uid 99); 22 Apr 2015 19:41:59 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 22 Apr 2015 19:41:59 +0000 Date: Wed, 22 Apr 2015 19:41:59 +0000 (UTC) From: "stack (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-13450) Purge RawBytescomparator from the writers and readers after HBASE-10800 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-13450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14507745#comment-14507745 ] stack commented on HBASE-13450: ------------------------------- Let Bytes.binarySearch take null for comparator and when this is case, use Bytes.RAW_COMPARATOR for default rather than do checks outside the method before calling into it. // As there is no BLOOM for META we could go with the Bytes.BYTES_COMPARATOR On above, please improve. Suggest: "hbase:meta does not use blooms so it is safe to do raw byte compares without having to do interpretation of the hbase:metas special row formatting. > Purge RawBytescomparator from the writers and readers after HBASE-10800 > ----------------------------------------------------------------------- > > Key: HBASE-13450 > URL: https://issues.apache.org/jira/browse/HBASE-13450 > Project: HBase > Issue Type: Sub-task > Reporter: ramkrishna.s.vasudevan > Assignee: ramkrishna.s.vasudevan > Fix For: 2.0.0 > > Attachments: HBASE-13450.patch, HBASE-13450_2.patch > > > Currently KeyValue.RAW_COMPARATOR is written in the Trailer of the HFiles. Ideally this need not be persisted to the trailer of the Hfiles because only the ROW bloom and the meta index blocks uses this. Currently RAW_COMPARATOR is also of type KVComparator. > HBASE-10800 would introduce CellComparator and would expect only cells to be compared. We cannot have RAW_COMPARATOR a type of CellComparator. Hence it is better to avoid writing the RAW_COMPARATOR to the FFT and whereever we need RAW_COMPARATOR we will directly use it as Bytes.BYTES_RAWCOMPARATOR. -- This message was sent by Atlassian JIRA (v6.3.4#6332)