Return-Path: 
 <issues-return-192969-apmail-hbase-issues-archive=hbase.apache.org@hbase.apache.org>
X-Original-To: apmail-hbase-issues-archive@www.apache.org
Delivered-To: apmail-hbase-issues-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 4D73E1733B
	for <apmail-hbase-issues-archive@www.apache.org>;
 Thu, 23 Apr 2015 13:34:42 +0000 (UTC)
Received: (qmail 32916 invoked by uid 500); 23 Apr 2015 13:34:39 -0000
Delivered-To: apmail-hbase-issues-archive@hbase.apache.org
Received: (qmail 32854 invoked by uid 500); 23 Apr 2015 13:34:39 -0000
Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@hbase.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@hbase.apache.org>
List-Post: <mailto:issues@hbase.apache.org>
List-Id: <issues.hbase.apache.org>
Delivered-To: mailing list issues@hbase.apache.org
Received: (qmail 32842 invoked by uid 99); 23 Apr 2015 13:34:39 -0000
Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 23 Apr 2015 13:34:38 +0000
Date: Thu, 23 Apr 2015 13:34:38 +0000 (UTC)
From: "stack (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.12820029.1428666303000.6328.1429796078938@Atlassian.JIRA>
In-Reply-To: <JIRA.12820029.1428666303000@Atlassian.JIRA>
References: <JIRA.12820029.1428666303000@Atlassian.JIRA>
 <JIRA.12820029.1428666303693@arcas>
Subject: [jira] [Commented] (HBASE-13450) Purge RawBytescomparator from the
 writers and readers after HBASE-10800
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394


    [ https://issues.apache.org/jira/browse/HBASE-13450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14509050#comment-14509050 ] 

stack commented on HBASE-13450:
-------------------------------

Why is the passing of a comparator binarySearch deprecated?

2079	  @Deprecated

Should say why in the (missing) @Deprecated that should be added to javadoc pointing folks at alternatives to use.

Ditto for the later binarySearch method that is deprecated (Is this only place that references Cell in Bytes?  Would be good to get Cell out of Bytes)

Do the overrides work? Isn't RawComparator<Cell> a subclass of Comparator<Cell>?  (The erasure would null out Cell?)  If it does, all well and good.

You could write the below:

586	      if (comparatorClass != null) {
587	        return comparatorClass.newInstance();
588	      } else {
589	        return null;
590	      }

as: return comparatorClass != null? comparatorClass.newInstance: null;

In below...

We could use Bytes.BYTES_RAWCOMPARATOR for ROW Bloom

instead of 'could' say, 'can safely' (two places)

Above can be fixed on commit. +1.

> Purge RawBytescomparator from the writers and readers after HBASE-10800
> -----------------------------------------------------------------------
>
>                 Key: HBASE-13450
>                 URL: https://issues.apache.org/jira/browse/HBASE-13450
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: ramkrishna.s.vasudevan
>             Fix For: 2.0.0
>
>         Attachments: HBASE-13450.patch, HBASE-13450_2.patch, HBASE-13450_3.patch
>
>
> Currently KeyValue.RAW_COMPARATOR is written in the Trailer of the HFiles.  Ideally this need not be persisted to the trailer of the Hfiles because only the ROW bloom and the meta index blocks uses this. Currently RAW_COMPARATOR is also of type KVComparator.
> HBASE-10800 would introduce CellComparator and would expect only cells to be compared.  We cannot have RAW_COMPARATOR a type of CellComparator.  Hence it is better to avoid writing the RAW_COMPARATOR to the FFT and whereever we need RAW_COMPARATOR we will directly use it as Bytes.BYTES_RAWCOMPARATOR.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)