Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 2862617AD3 for ; Wed, 8 Apr 2015 16:31:13 +0000 (UTC) Received: (qmail 29750 invoked by uid 500); 8 Apr 2015 16:31:13 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 29702 invoked by uid 500); 8 Apr 2015 16:31:12 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 29681 invoked by uid 99); 8 Apr 2015 16:31:12 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 08 Apr 2015 16:31:12 +0000 Date: Wed, 8 Apr 2015 16:31:12 +0000 (UTC) From: "stack (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-13421) Reduce the number of object creations introduced by HBASE-11544 in scan RPC hot code paths MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-13421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14485476#comment-14485476 ] stack commented on HBASE-13421: ------------------------------- I pushed to master (with checkstyle fixes to get us under limit again). Backport is a little bit of work... [~jonathan.lawlor] You game? > Reduce the number of object creations introduced by HBASE-11544 in scan RPC hot code paths > ------------------------------------------------------------------------------------------ > > Key: HBASE-13421 > URL: https://issues.apache.org/jira/browse/HBASE-13421 > Project: HBase > Issue Type: Sub-task > Reporter: Jonathan Lawlor > Assignee: Jonathan Lawlor > Fix For: 2.0.0, 1.1.0 > > Attachments: HBASE-13421-v1.patch, HBASE-13421-v2.patch > > > HBASE-11544 made NextState the new return type of RegionScanner#nextRaw InternalScanner#next to allow state information to be passed back from a scanner (it was formerly a boolean indicating whether or not more values existed). The change in this return type led to an increased amount of objects being created... In the case that a scan spanned millions of rows, there was the potential for millions of object to be created. > This issue looks to reduce the large amount of object creations from potentially many to at most one per RPC request. > Please see the tail of the parent issue for relevant discussion on the design decisions related to this solution. This sub-task has been filed as it seems more appropriate to address the fix here rather than as an addendum to the parent. -- This message was sent by Atlassian JIRA (v6.3.4#6332)