Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Wed, 22 Apr 2015 06:11:00 +0000 (UTC)
From: "Anoop Sam John (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.12787254.1427865300000.71606.1429683060014@Atlassian.JIRA>
In-Reply-To: <JIRA.12787254.1427865300000@Atlassian.JIRA>
References: <JIRA.12787254.1427865300000@Atlassian.JIRA>
 <JIRA.12787254.1427865300272@arcas>
Subject: [jira] [Commented] (HBASE-13375) Provide HBase superuser higher
 priority over other users in the RPC handling
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HBASE-13375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14506495#comment-14506495 ] 

Anoop Sam John commented on HBASE-13375:
----------------------------------------

bq.if (User.isSuperUser(user, conf)) 
Can we have isSuperUser () method as an instance method so no need to pass the user?

bq.String group = User.getGroupName(Bytes.toString(user));
I am not sure whethere this method realy fits in User class.  This is a util method which strips @ from the name.  

User#getSuperGroups
if (superGroups == null) {
	superGroups = new ArrayList<>();

Instead we can create a local List first, add all items to that and set it to the static variable at once? 
Same in getSuperUesrs


> Provide HBase superuser higher priority over other users in the RPC handling
> ----------------------------------------------------------------------------
>
>                 Key: HBASE-13375
>                 URL: https://issues.apache.org/jira/browse/HBASE-13375
>             Project: HBase
>          Issue Type: Improvement
>          Components: rpc
>            Reporter: Devaraj Das
>            Assignee: Mikhail Antonov
>             Fix For: 1.1.0
>
>         Attachments: HBASE-13375-v0.patch, HBASE-13375-v1.patch, HBASE-13375-v1.patch, HBASE-13375-v1.patch, HBASE-13375-v2.patch, HBASE-13375-v3.patch
>
>
> HBASE-13351 annotates Master RPCs so that RegionServer RPCs are treated with a higher priority compared to user RPCs (and they are handled by a separate set of handlers, etc.). It may be good to stretch this to users too - hbase superuser (configured via hbase.superuser) gets higher priority over other users in the RPC handling. That way the superuser can always perform administrative operations on the cluster even if all the normal priority handlers are occupied (for example, we had a situation where all the master's handlers were tied up with many simultaneous createTable RPC calls from multiple users and the master wasn't able to perform any operations initiated by the admin). (Discussed this some with [~enis] and [~elserj]).
> Does this make sense to others?


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)