Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Tue, 28 Apr 2015 11:58:07 +0000 (UTC)
From: "Matt Warhaftig (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.12786504.1427611818000.6477.1430222287605@Atlassian.JIRA>
In-Reply-To: <JIRA.12786504.1427611818000@Atlassian.JIRA>
References: <JIRA.12786504.1427611818000@Atlassian.JIRA>
 <JIRA.12786504.1427611818114@arcas>
Subject: [jira] [Commented] (HBASE-13358) Upgrade VisibilityClient API to
 accept Connection object.
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HBASE-13358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14516922#comment-14516922 ] 

Matt Warhaftig commented on HBASE-13358:
----------------------------------------

Thanks for the fast feedback [~anoop.hbase] and [~srikanth235].  

{quote}Without patch, we're using connection with system user as default. But this changes is making use of SUPERUSER_CONN by default. {quote}
When we are in SUPERUSER's context a VisibilityClient call of ConnectionFactory.createConnection(conf) results in an Admin user.  My belief was that pre-patch, the user was whoever's context VisibilityClient was called from and outside of runAs() it was the system user.

However, this question is unnecessary as I like your idea of creating the connection before each VisibilityClient method call.  Will resubmit patch with changes tonight.

> Upgrade VisibilityClient API to accept Connection object.
> ---------------------------------------------------------
>
>                 Key: HBASE-13358
>                 URL: https://issues.apache.org/jira/browse/HBASE-13358
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Srikanth Srungarapu
>            Assignee: Matt Warhaftig
>            Priority: Minor
>             Fix For: 2.0.0
>
>         Attachments: HBASE-13358.patch, HBASE-13358_v2.patch
>
>
> From VisibilityClient class:
> {code}
>   // TODO: Make it so caller passes in a Connection rather than have us do this expensive
>     // setup each time.  This class only used in test and shell at moment though.
> {code}
> Basically, this is the VC's counterpart of HBASE-13171. 


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)