Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D71D018A8D for ; Wed, 29 Apr 2015 12:39:07 +0000 (UTC) Received: (qmail 62941 invoked by uid 500); 29 Apr 2015 12:39:07 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 62895 invoked by uid 500); 29 Apr 2015 12:39:07 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 62883 invoked by uid 99); 29 Apr 2015 12:39:07 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 29 Apr 2015 12:39:07 +0000 Date: Wed, 29 Apr 2015 12:39:07 +0000 (UTC) From: "Anoop Sam John (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-13358) Upgrade VisibilityClient API to accept Connection object. MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-13358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14519273#comment-14519273 ] Anoop Sam John commented on HBASE-13358: ---------------------------------------- nit on Javadoc Instead of adding like Use {@code VisibilityClient.addLabel(Connection,String)} instead. in javadoc, go with {@link #addLabel(Connection,String)} (?) > Upgrade VisibilityClient API to accept Connection object. > --------------------------------------------------------- > > Key: HBASE-13358 > URL: https://issues.apache.org/jira/browse/HBASE-13358 > Project: HBase > Issue Type: Improvement > Reporter: Srikanth Srungarapu > Assignee: Matt Warhaftig > Priority: Minor > Fix For: 2.0.0 > > Attachments: HBASE-13358.patch, HBASE-13358_v2.patch, HBASE-13358_v3.patch > > > From VisibilityClient class: > {code} > // TODO: Make it so caller passes in a Connection rather than have us do this expensive > // setup each time. This class only used in test and shell at moment though. > {code} > Basically, this is the VC's counterpart of HBASE-13171. -- This message was sent by Atlassian JIRA (v6.3.4#6332)