Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Thu, 2 Apr 2015 04:51:53 +0000 (UTC)
From: "Andrew Purtell (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.12785937.1427389599000.102867.1427950313231@Atlassian.JIRA>
In-Reply-To: <JIRA.12785937.1427389599000@Atlassian.JIRA>
References: <JIRA.12785937.1427389599000@Atlassian.JIRA>
 <JIRA.12785937.1427389599810@arcas>
Subject: [jira] [Commented] (HBASE-13340) Include LimitedPrivate interfaces
 in the API compatibility report
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HBASE-13340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14392140#comment-14392140 ] 

Andrew Purtell commented on HBASE-13340:
----------------------------------------

bq. Any reason to explicitly declare the array?
Strictly pedantry / documentation. 

Thanks for the review [~dimaspivak]

> Include LimitedPrivate interfaces in the API compatibility report
> -----------------------------------------------------------------
>
>                 Key: HBASE-13340
>                 URL: https://issues.apache.org/jira/browse/HBASE-13340
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Andrew Purtell
>            Assignee: Andrew Purtell
>            Priority: Minor
>             Fix For: 2.0.0
>
>         Attachments: HBASE-13340.patch
>
>
> The API compatibility checker script added in HBASE-12808 passes a file containing annotations to the JavaACC tool. When JavaACC is invoked with that option it will filter out all interfaces that do not have that annotation. Currently only Public interfaces are checked. We should add LimitedPrivate to the annotation list, otherwise we will miss changes that impact coprocessors and other users of those interfaces.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)