Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id AE03517F28 for ; Mon, 13 Apr 2015 18:25:14 +0000 (UTC) Received: (qmail 68373 invoked by uid 500); 13 Apr 2015 18:25:14 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 68327 invoked by uid 500); 13 Apr 2015 18:25:14 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 68314 invoked by uid 99); 13 Apr 2015 18:25:14 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 13 Apr 2015 18:25:14 +0000 Date: Mon, 13 Apr 2015 18:25:14 +0000 (UTC) From: "Nick Dimiduk (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-13078) IntegrationTestSendTraceRequests is a noop MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-13078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14492789#comment-14492789 ] Nick Dimiduk commented on HBASE-13078: -------------------------------------- My thinking is that we should have both: a medium or large test that verifies a single traced invocation with everything enabled results in spans logged (and perhaps some validation thereof) as well as a smoke test like this one that can be run to validate tracing is configured correctly cluster-wide (ie, and spans are coming out of both hbase and hdfs). Maybe the latter is unreasonable? Anyway, nice work [~elserj], +1. > IntegrationTestSendTraceRequests is a noop > ------------------------------------------ > > Key: HBASE-13078 > URL: https://issues.apache.org/jira/browse/HBASE-13078 > Project: HBase > Issue Type: Test > Components: integration tests > Reporter: Nick Dimiduk > Assignee: Josh Elser > Priority: Critical > Fix For: 2.0.0, 1.1.0, 0.98.13, 1.0.2 > > Attachments: HBASE-13078-0.98-removal.patch, HBASE-13078-0.98-v1.patch, HBASE-13078-v1.patch, HBASE-13078.patch > > > While pair-debugging with [~jeffreyz] on HBASE-13077, we noticed that IntegrationTestSendTraceRequests doesn't actually assert anything. This test should be converted to use a mini cluster, setup a POJOSpanReceiver, and then verify the spans collected. -- This message was sent by Atlassian JIRA (v6.3.4#6332)