Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 0D2131012C for ; Mon, 27 Apr 2015 09:42:40 +0000 (UTC) Received: (qmail 14305 invoked by uid 500); 27 Apr 2015 09:42:39 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 14257 invoked by uid 500); 27 Apr 2015 09:42:39 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 14245 invoked by uid 99); 27 Apr 2015 09:42:39 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 27 Apr 2015 09:42:39 +0000 Date: Mon, 27 Apr 2015 09:42:39 +0000 (UTC) From: "Usha Kuchibhotla (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (HBASE-11677) Make Logger instance modifiers consistent MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-11677?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Usha Kuchibhotla updated HBASE-11677: ------------------------------------- Attachment: HBase-11677-v6.patch Change the modifier in TableSplit class back to public as ithe class is marked @InterfaceAudience.Public. > Make Logger instance modifiers consistent > ----------------------------------------- > > Key: HBASE-11677 > URL: https://issues.apache.org/jira/browse/HBASE-11677 > Project: HBase > Issue Type: Task > Reporter: Sean Busbey > Priority: Minor > Labels: beginner, sonar > Attachments: HBASE-11677-v1.patch, HBASE-11677-v2.patch, HBASE-11677-v3.patch, HBASE-11677-v4.patch, HBASE-11677.patch, HBase-11677-v5.patch, HBase-11677-v6.patch, HBase-11677-v6.patch > > > We have some instances of Logger that are missing one of being private, static, and final. > ex from HealthChecker.java, missing final > {code} > private static Log LOG = LogFactory.getLog(HealthChecker.class); > {code} > * Clean up where possible by making {{private static final}} > * If we can't, add a non-javadoc note about why > One way to look for problematic instances is to grep for initial assignment for the commonly used LOG member, e.g. > * missing final: {{grep -r "LOG =" * | grep -v "final"}} > * missing static: {{grep -r "LOG =" * | grep -v "static"}} > * missing private: {{grep -r "LOG =" * | grep -v "private"}} -- This message was sent by Atlassian JIRA (v6.3.4#6332)