Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 2C01F17F4D for ; Fri, 3 Apr 2015 12:07:54 +0000 (UTC) Received: (qmail 12900 invoked by uid 500); 3 Apr 2015 12:07:54 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 12850 invoked by uid 500); 3 Apr 2015 12:07:54 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 12836 invoked by uid 99); 3 Apr 2015 12:07:53 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 03 Apr 2015 12:07:53 +0000 Date: Fri, 3 Apr 2015 12:07:53 +0000 (UTC) From: "Hadoop QA (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-10800) Use CellComparator instead of KVComparator MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-10800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14394348#comment-14394348 ] Hadoop QA commented on HBASE-10800: ----------------------------------- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12709202/HBASE-10800_3.patch against master branch at commit d8b10656d00779e194c3caca118995136babce99. ATTACHMENT ID: 12709202 {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 146 new or modified tests. {color:green}+1 hadoop versions{color}. The patch compiles with all supported hadoop versions (2.4.1 2.5.2 2.6.0) {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 protoc{color}. The applied patch does not increase the total number of protoc compiler warnings. {color:red}-1 javadoc{color}. The javadoc tool appears to have generated 16 warning messages. {color:red}-1 checkstyle{color}. The applied patch generated 1945 checkstyle errors (more than the master's current 1924 errors). {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 2.0.3) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:red}-1 lineLengths{color}. The patch introduces the following lines longer than 100: + public int compareRows(Cell left, int loffset, int llength, Cell right, int roffset, int rlength) { + public int compareRows(Cell left, int loffset, int llength, byte[] right, int roffset, int rlength) { + Bytes.putLong(newKey, rightKey.length - KeyValue.TIMESTAMP_TYPE_SIZE, HConstants.LATEST_TIMESTAMP); + && leftKey[KeyValue.ROW_LENGTH_SIZE + diffIdx] == rightKey[KeyValue.ROW_LENGTH_SIZE + diffIdx]) { + public int compareRows(Cell left, int loffset, int llength, Cell right, int roffset, int rlength) { + public static int findCommonPrefixInQualifierPart(Cell left, Cell right, int qualifierCommonPrefix) { + public static int getDelimiter(final byte[] b, int offset, final int length, final int delimiter) { + comp = samePrefixComparator.compareCommonRowPrefix(seekCell, currentCell, rowCommonPrefix); + public EncodedSeeker createSeeker(CellComparator comparator, HFileBlockDecodingContext decodingCtx) { {color:green}+1 site{color}. The mvn site goal succeeds with this patch. {color:red}-1 core tests{color}. The patch failed these unit tests: org.apache.hadoop.hbase.client.TestScannerTimeout org.apache.hadoop.hbase.replication.regionserver.TestReplicationWALReaderManager org.apache.hadoop.hbase.wal.TestBoundedRegionGroupingProvider org.apache.hadoop.hbase.regionserver.wal.TestWALReplay org.apache.hadoop.hbase.regionserver.TestCompoundBloomFilter org.apache.hadoop.hbase.wal.TestDefaultWALProviderWithHLogKey org.apache.hadoop.hbase.wal.TestDefaultWALProvider org.apache.hadoop.hbase.replication.TestReplicationKillMasterRS org.apache.hadoop.hbase.replication.regionserver.TestRegionReplicaReplicationEndpoint org.apache.hadoop.hbase.regionserver.TestHRegionReplayEvents org.apache.hadoop.hbase.regionserver.wal.TestLogRolling org.apache.hadoop.hbase.replication.TestReplicationDisableInactivePeer org.apache.hadoop.hbase.mapreduce.TestWALRecordReader org.apache.hadoop.hbase.replication.regionserver.TestReplicationSink org.apache.hadoop.hbase.replication.TestReplicationKillSlaveRS org.apache.hadoop.hbase.replication.TestReplicationSource org.apache.hadoop.hbase.security.visibility.TestVisibilityLabelsReplication org.apache.hadoop.hbase.TestZooKeeper org.apache.hadoop.hbase.regionserver.TestRegionReplicaFailover org.apache.hadoop.hbase.mapreduce.TestHLogRecordReader org.apache.hadoop.hbase.wal.TestWALFactory org.apache.hadoop.hbase.security.visibility.TestVisibilityLabelReplicationWithExpAsString org.apache.hadoop.hbase.regionserver.wal.TestDurability org.apache.hadoop.hbase.mapreduce.TestWALPlayer org.apache.hadoop.hbase.wal.TestWALSplit org.apache.hadoop.hbase.replication.TestReplicationSyncUpTool org.apache.hadoop.hbase.TestFullLogReconstruction org.apache.hadoop.hbase.replication.TestPerTableCFReplication org.apache.hadoop.hbase.master.TestDistributedLogSplitting org.apache.hadoop.hbase.replication.TestReplicationWithTags org.apache.hadoop.hbase.regionserver.TestHRegion org.apache.hadoop.hbase.regionserver.TestHRegionOnCluster org.apache.hadoop.hbase.replication.TestMultiSlaveReplication org.apache.hadoop.hbase.replication.TestReplicationEndpoint org.apache.hadoop.hbase.replication.TestReplicationKillMasterRSCompressed org.apache.hadoop.hbase.replication.TestReplicationSmallTests org.apache.hadoop.hbase.replication.TestReplicationChangingPeerRegionservers org.apache.hadoop.hbase.security.visibility.TestVisibilityLabelsWithDistributedLogReplay org.apache.hadoop.hbase.security.visibility.TestVisibilityLabelsWithDefaultVisLabelService org.apache.hadoop.hbase.regionserver.wal.TestProtobufLog org.apache.hadoop.hbase.replication.TestMasterReplication org.apache.hadoop.hbase.regionserver.TestPerColumnFamilyFlush {color:red}-1 core zombie tests{color}. There are 6 zombie test(s): at org.apache.hadoop.hbase.master.TestRegionPlacement.testRegionPlacement(TestRegionPlacement.java:109) at org.apache.hadoop.hbase.client.TestFromClientSide3.testHTableExistsMethodMultipleRegionsMultipleGets(TestFromClientSide3.java:380) at org.apache.hadoop.hbase.client.TestAdmin1.testTruncateTable(TestAdmin1.java:392) at org.apache.hadoop.hbase.client.TestAdmin1.testTruncateTable(TestAdmin1.java:374) at org.apache.hadoop.hbase.snapshot.TestExportSnapshot.testExportFileSystemState(TestExportSnapshot.java:287) at org.apache.hadoop.hbase.snapshot.TestExportSnapshot.testConsecutiveExports(TestExportSnapshot.java:211) at org.apache.hadoop.hbase.snapshot.TestExportSnapshot.testExportFileSystemState(TestExportSnapshot.java:287) at org.apache.hadoop.hbase.snapshot.TestExportSnapshot.testExportFileSystemState(TestExportSnapshot.java:261) at org.apache.hadoop.hbase.snapshot.TestExportSnapshot.testSnapshotWithRefsExportFileSystemState(TestExportSnapshot.java:255) at org.apache.hadoop.hbase.snapshot.TestExportSnapshot.testSnapshotWithRefsExportFileSystemState(TestExportSnapshot.java:239) Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/13551//testReport/ Release Findbugs (version 2.0.3) warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13551//artifact/patchprocess/newFindbugsWarnings.html Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/13551//artifact/patchprocess/checkstyle-aggregate.html Javadoc warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13551//artifact/patchprocess/patchJavadocWarnings.txt Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/13551//console This message is automatically generated. > Use CellComparator instead of KVComparator > ------------------------------------------ > > Key: HBASE-10800 > URL: https://issues.apache.org/jira/browse/HBASE-10800 > Project: HBase > Issue Type: Sub-task > Reporter: ramkrishna.s.vasudevan > Assignee: ramkrishna.s.vasudevan > Fix For: 1.1.0 > > Attachments: HBASE-10800_1.patch, HBASE-10800_2.patch, HBASE-10800_3.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)