Return-Path: 
 <issues-return-190400-apmail-hbase-issues-archive=hbase.apache.org@hbase.apache.org>
X-Original-To: apmail-hbase-issues-archive@www.apache.org
Delivered-To: apmail-hbase-issues-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 8CEDA17BAB
	for <apmail-hbase-issues-archive@www.apache.org>;
 Tue,  7 Apr 2015 10:42:16 +0000 (UTC)
Received: (qmail 19172 invoked by uid 500); 7 Apr 2015 10:42:16 -0000
Delivered-To: apmail-hbase-issues-archive@hbase.apache.org
Received: (qmail 19135 invoked by uid 500); 7 Apr 2015 10:42:16 -0000
Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@hbase.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@hbase.apache.org>
List-Post: <mailto:issues@hbase.apache.org>
List-Id: <issues.hbase.apache.org>
Delivered-To: mailing list issues@hbase.apache.org
Received: (qmail 19123 invoked by uid 99); 7 Apr 2015 10:42:16 -0000
Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 07 Apr 2015 10:42:16 +0000
Date: Tue, 7 Apr 2015 10:42:16 +0000 (UTC)
From: "Lars Francke (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.12541896.1328743055000.13362.1428403336233@Atlassian.JIRA>
In-Reply-To: <JIRA.12541896.1328743055000@Atlassian.JIRA>
References: <JIRA.12541896.1328743055000@Atlassian.JIRA>
 <JIRA.12541896.1328743055187@arcas>
Subject: [jira] [Updated] (HBASE-5357) Use builder pattern in
 HColumnDescriptor
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394


     [ https://issues.apache.org/jira/browse/HBASE-5357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Lars Francke updated HBASE-5357:
--------------------------------
    Fix Version/s:     (was: 0.96.0)

> Use builder pattern in HColumnDescriptor
> ----------------------------------------
>
>                 Key: HBASE-5357
>                 URL: https://issues.apache.org/jira/browse/HBASE-5357
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Mikhail Bautin
>            Assignee: Mikhail Bautin
>         Attachments: ASF.LICENSE.NOT.GRANTED--D1851.1.patch, ASF.LICENSE.NOT.GRANTED--D1851.2.patch, ASF.LICENSE.NOT.GRANTED--D1851.3.patch, ASF.LICENSE.NOT.GRANTED--D1851.4.patch, ASF.LICENSE.NOT.GRANTED--D1929.1.patch, ASF.LICENSE.NOT.GRANTED--D1929.2.patch, Use-builder-pattern-for-HColumnDescriptor-2012-02-21_19_13_35.patch, Use-builder-pattern-for-HColumnDescriptor-2012-02-23_12_42_49.patch, Use-builder-pattern-for-HColumnDescriptor-20120223113155-e387d251.patch
>
>
> We have five ways to create an HFile writer, two ways to create a StoreFile writer, and the sets of parameters keep changing, creating a lot of confusion, especially when porting patches across branches. The same thing is happening to HColumnDescriptor. I think we should move to a "builder pattern" solution, e.g.
> {code:java}
>   HFileWriter w = HFile.getWriterBuilder(conf, <some common args>)
>       .setParameter1(value1)
>       .setParameter2(value2)
>       ...
>       .build();
> {code}
> Each parameter setter being on its own line will make merges/cherry-pick work properly, we will not have to even mention default parameters again, and we can eliminate a dozen impossible-to-remember constructors.
> This particular JIRA addresses the HColumnDescriptor refactoring. For StoreFile/HFile refactoring see HBASE-5442.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)