hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-13585) HRegionFileSystem#splitStoreFile() finishes without closing the file handle in some situation
Date Tue, 28 Apr 2015 21:49:06 GMT

    [ https://issues.apache.org/jira/browse/HBASE-13585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14518157#comment-14518157
] 

Hadoop QA commented on HBASE-13585:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12728881/HBASE-13585.v1-mater.patch
  against master branch at commit d2c19416a2afb6c47f79037702411bb63a80e9e6.
  ATTACHMENT ID: 12728881

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 hadoop versions{color}. The patch compiles with all supported hadoop versions
(2.4.1 2.5.2 2.6.0)

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 protoc{color}.  The applied patch does not increase the total number of
protoc compiler warnings.

    {color:red}-1 javadoc{color}.  The javadoc tool appears to have generated 2 warning messages.

    {color:green}+1 checkstyle{color}.  The applied patch does not increase the total number
of checkstyle errors

    {color:green}+1 findbugs{color}.  The patch does not introduce any  new Findbugs (version
2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines longer than 100

  {color:green}+1 site{color}.  The mvn site goal succeeds with this patch.

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/13867//testReport/
Release Findbugs (version 2.0.3) 	warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13867//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/13867//artifact/patchprocess/checkstyle-aggregate.html

  Javadoc warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13867//artifact/patchprocess/patchJavadocWarnings.txt
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/13867//console

This message is automatically generated.

> HRegionFileSystem#splitStoreFile() finishes without closing the file handle in some situation
> ---------------------------------------------------------------------------------------------
>
>                 Key: HBASE-13585
>                 URL: https://issues.apache.org/jira/browse/HBASE-13585
>             Project: HBase
>          Issue Type: Bug
>          Components: regionserver
>    Affects Versions: 2.0.0, 1.1.0, 1.2.0
>         Environment: Windows
>            Reporter: Stephen Yuan Jiang
>            Assignee: Stephen Yuan Jiang
>         Attachments: HBASE-13585.v1-mater.patch
>
>
> HRegionFileSystem#splitStoreFile() opens a reader and does not close it in some situation.
 
> In Windows, TestSplitTransaction#testWholesomeSplit() consistently failed due to open
file handle left at the end of test
> {noformat}
> Failed delete of C:/hbase/hbase-server/target/test-data/b470118c-978a-4915-8a12-b29b2c966beb/org.apache.hadoop.hbase.regionserver.TestSplitTransaction/data/default/table/a578b53b3c3a947c5f617c51ccb982cf
> Stacktrace
> java.io.IOException: Failed delete of C:/hbase/hbase-server/target/test-data/b470118c-978a-4915-8a12-b29b2c966beb/org.apache.hadoop.hbase.regionserver.TestSplitTransaction/data/default/table/a578b53b3c3a947c5f617c51ccb982cf
> 	at org.apache.hadoop.hbase.regionserver.TestSplitTransaction.teardown(TestSplitTransaction.java:106)
> Standard Error
> 2015-04-26 12:57:43,863 WARN  [main] fs.FileUtil(187): Failed to delete file or dir [C:\hbase\hbase-server\target\test-data\b470118c-978a-4915-8a12-b29b2c966beb\org.apache.hadoop.hbase.regionserver.TestSplitTransaction\data\default\table\a578b53b3c3a947c5f617c51ccb982cf\info\.0519debf2b934245a9a8c3d7cfc0f51d.crc]:
it still exists.
> 2015-04-26 12:57:43,864 WARN  [main] fs.FileUtil(187): Failed to delete file or dir [C:\hbase\hbase-server\target\test-data\b470118c-978a-4915-8a12-b29b2c966beb\org.apache.hadoop.hbase.regionserver.TestSplitTransaction\data\default\table\a578b53b3c3a947c5f617c51ccb982cf\info\.45fd4e817ce64759abc6e982a5c0b830.crc]:
it still exists.
> 2015-04-26 12:57:43,865 WARN  [main] fs.FileUtil(187): Failed to delete file or dir [C:\hbase\hbase-server\target\test-data\b470118c-978a-4915-8a12-b29b2c966beb\org.apache.hadoop.hbase.regionserver.TestSplitTransaction\data\default\table\a578b53b3c3a947c5f617c51ccb982cf\info\.8e6bc752c9fc414abfe085f8959dce94.crc]:
it still exists.
> 2015-04-26 12:57:43,870 WARN  [main] fs.FileUtil(187): Failed to delete file or dir [C:\hbase\hbase-server\target\test-data\b470118c-978a-4915-8a12-b29b2c966beb\org.apache.hadoop.hbase.regionserver.TestSplitTransaction\data\default\table\a578b53b3c3a947c5f617c51ccb982cf\info\0519debf2b934245a9a8c3d7cfc0f51d]:
it still exists.
> 2015-04-26 12:57:43,870 WARN  [main] fs.FileUtil(187): Failed to delete file or dir [C:\hbase\hbase-server\target\test-data\b470118c-978a-4915-8a12-b29b2c966beb\org.apache.hadoop.hbase.regionserver.TestSplitTransaction\data\default\table\a578b53b3c3a947c5f617c51ccb982cf\info\45fd4e817ce64759abc6e982a5c0b830]:
it still exists.
> 2015-04-26 12:57:43,871 WARN  [main] fs.FileUtil(187): Failed to delete file or dir [C:\hbase\hbase-server\target\test-data\b470118c-978a-4915-8a12-b29b2c966beb\org.apache.hadoop.hbase.regionserver.TestSplitTransaction\data\default\table\a578b53b3c3a947c5f617c51ccb982cf\info\8e6bc752c9fc414abfe085f8959dce94]:
it still exists.
> {noformat}
> HBASE-8300 tried to fix this issue by adding 'StoreFile#closeReader()' call.  However,
after the open reader calls, there are 4 'return null' calls before the close call.  When
I run TestSplitTransaction#testWholesomeSplit(), 2 of the 'return null' calls were hit multiple
times (which means the opened file is not closed).  
> The fix needs to make sure that StoreFile#closeReader() is called in all situation.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message