hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Enis Soztutar (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-13568) Make Waiter class a public API.
Date Mon, 27 Apr 2015 06:28:39 GMT

    [ https://issues.apache.org/jira/browse/HBASE-13568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14513604#comment-14513604
] 

Enis Soztutar commented on HBASE-13568:
---------------------------------------

I guess you were mentioning my review comment. I was implying that we can re-use Waiter that
we have already in the proc code. The intention was not to make it a public class, but merely
moving from tests to main thus making it useable internally. I don't think we should make
Waiter a public API. 

> Make Waiter class a public API.
> -------------------------------
>
>                 Key: HBASE-13568
>                 URL: https://issues.apache.org/jira/browse/HBASE-13568
>             Project: HBase
>          Issue Type: Task
>            Reporter: Srikanth Srungarapu
>            Assignee: Srikanth Srungarapu
>            Priority: Minor
>         Attachments: HBASE-13568.patch, HBASE-13568_v2.patch
>
>
> During ProcV2 code reviews, it is suggested that Waiter class is useful enough to make
it a public API. This change decomposes the existing Waiter class into two classes, one for
public use and the other exclusively for the internal testing.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message