hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-13551) Procedure V2 - Procedure classes should not be InterfaceAudience.Public
Date Tue, 28 Apr 2015 06:21:07 GMT

    [ https://issues.apache.org/jira/browse/HBASE-13551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14516478#comment-14516478
] 

Hudson commented on HBASE-13551:
--------------------------------

SUCCESS: Integrated in HBase-1.1 #437 (See [https://builds.apache.org/job/HBase-1.1/437/])
HBASE-13551 Procedure V2 - Procedure classes should not be InterfaceAudience.Public (enis:
rev 24fbd9b769899da6c11ba8115cba986d905c77e2)
* hbase-procedure/src/main/java/org/apache/hadoop/hbase/procedure2/ProcedureAbortedException.java
* hbase-procedure/src/main/java/org/apache/hadoop/hbase/procedure2/ProcedureResult.java
* hbase-procedure/src/main/java/org/apache/hadoop/hbase/procedure2/store/ProcedureStore.java
* hbase-procedure/src/main/java/org/apache/hadoop/hbase/procedure2/ProcedureException.java
* hbase-procedure/src/main/java/org/apache/hadoop/hbase/procedure2/StateMachineProcedure.java
* hbase-procedure/src/main/java/org/apache/hadoop/hbase/procedure2/TwoPhaseProcedure.java
* hbase-procedure/src/main/java/org/apache/hadoop/hbase/procedure2/OnePhaseProcedure.java
* hbase-procedure/src/main/java/org/apache/hadoop/hbase/procedure2/RemoteProcedureException.java
* hbase-procedure/src/main/java/org/apache/hadoop/hbase/procedure2/SequentialProcedure.java
* hbase-procedure/src/main/java/org/apache/hadoop/hbase/procedure2/ProcedureYieldException.java


> Procedure V2 - Procedure classes should not be InterfaceAudience.Public
> -----------------------------------------------------------------------
>
>                 Key: HBASE-13551
>                 URL: https://issues.apache.org/jira/browse/HBASE-13551
>             Project: HBase
>          Issue Type: Sub-task
>          Components: master
>            Reporter: Enis Soztutar
>            Assignee: Enis Soztutar
>            Priority: Blocker
>             Fix For: 2.0.0, 1.1.0, 1.2.0
>
>         Attachments: hbase-13551_v1.patch
>
>
> Just noticed this. We have ProcedureStore, and exceptions and some procedures declared
as {{InterfaceAudience.Public}}. We should really make them Private or LimiterPrivate since
Public is for user comsumption. Are we exposing Procedures to coprocessors? I do not see a
use case for that, so it should be Private IMO.  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message