hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matteo Bertozzi (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-13551) Procedure V2 - Procedure classes should not be InterfaceAudience.Public
Date Fri, 24 Apr 2015 07:28:38 GMT

    [ https://issues.apache.org/jira/browse/HBASE-13551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14510601#comment-14510601
] 

Matteo Bertozzi commented on HBASE-13551:
-----------------------------------------

yeah, that private/public is not explanatory enough.
since it is in its own module I was dividing in "private" framework stuff only the framework
has access to (e.g. the RootProcedureState) and "public" the things the procedure implementor
can use.
of course it is all on the server side, the client will never interact with this stuff. but
people my implement its custom procedure, e.g. phoenix may build it's custom procedure so
"*Procedure" should be "public" to use. maybe limited private? not sure that private/public
doesn't really mean anything. can we add a Client/Server public private it will be a bit better

> Procedure V2 - Procedure classes should not be InterfaceAudience.Public
> -----------------------------------------------------------------------
>
>                 Key: HBASE-13551
>                 URL: https://issues.apache.org/jira/browse/HBASE-13551
>             Project: HBase
>          Issue Type: Sub-task
>          Components: master
>            Reporter: Enis Soztutar
>            Assignee: Enis Soztutar
>             Fix For: 2.0.0, 1.1.0
>
>         Attachments: hbase-13551_v1.patch
>
>
> Just noticed this. We have ProcedureStore, and exceptions and some procedures declared
as {{InterfaceAudience.Public}}. We should really make them Private or LimiterPrivate since
Public is for user comsumption. Are we exposing Procedures to coprocessors? I do not see a
use case for that, so it should be Private IMO.  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message