hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-13529) Procedure v2 - WAL Improvements
Date Wed, 22 Apr 2015 17:10:59 GMT

    [ https://issues.apache.org/jira/browse/HBASE-13529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14507433#comment-14507433
] 

Hadoop QA commented on HBASE-13529:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12727240/HBASE-13529-v1.patch
  against master branch at commit 23960207527b685609cd01259efbeb98f077b209.
  ATTACHMENT ID: 12727240

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 hadoop versions{color}. The patch compiles with all supported hadoop versions
(2.4.1 2.5.2 2.6.0)

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 protoc{color}.  The applied patch does not increase the total number of
protoc compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 checkstyle{color}.  The applied patch does not increase the total number
of checkstyle errors

    {color:green}+1 findbugs{color}.  The patch does not introduce any  new Findbugs (version
2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines longer than 100

  {color:green}+1 site{color}.  The mvn site goal succeeds with this patch.

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/13775//testReport/
Release Findbugs (version 2.0.3) 	warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13775//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/13775//artifact/patchprocess/checkstyle-aggregate.html

  Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/13775//console

This message is automatically generated.

> Procedure v2 - WAL Improvements
> -------------------------------
>
>                 Key: HBASE-13529
>                 URL: https://issues.apache.org/jira/browse/HBASE-13529
>             Project: HBase
>          Issue Type: Sub-task
>          Components: proc-v2
>    Affects Versions: 2.0.0, 1.1.0
>            Reporter: Matteo Bertozzi
>            Assignee: Matteo Bertozzi
>            Priority: Minor
>             Fix For: 2.0.0, 1.1.0
>
>         Attachments: HBASE-13529-v0.patch, HBASE-13529-v1.patch, ProcedureStoreTest.java
>
>
> from the discussion in HBASE-12439 the wal was resulting slow.
>  * there is an error around the awake of the slotCond.await(), causing more wait then
necessary
>  * ArrayBlockingQueue is dog slow, replace it with ConcurrentLinkedQueue
>  * roll the wal only if reaches a threshold (conf ops) to amortize the cost
>  * hsync() is used by default, when the normal wal is using just hflush() make it tunable
via conf



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message