hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-13518) Typo in hbase.hconnection.meta.lookup.threads.core parameter
Date Tue, 28 Apr 2015 04:51:07 GMT

    [ https://issues.apache.org/jira/browse/HBASE-13518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14516355#comment-14516355
] 

Hadoop QA commented on HBASE-13518:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12728614/13518-1.txt
  against master branch at commit 01188f0e86a75b45261a7c02dd64b42e813f981a.
  ATTACHMENT ID: 12728614

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 hadoop versions{color}. The patch compiles with all supported hadoop versions
(2.4.1 2.5.2 2.6.0)

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 protoc{color}.  The applied patch does not increase the total number of
protoc compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 checkstyle{color}.  The applied patch does not increase the total number
of checkstyle errors

    {color:green}+1 findbugs{color}.  The patch does not introduce any  new Findbugs (version
2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines longer than 100

  {color:green}+1 site{color}.  The mvn site goal succeeds with this patch.

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/13858//testReport/
Release Findbugs (version 2.0.3) 	warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13858//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/13858//artifact/patchprocess/checkstyle-aggregate.html

  Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/13858//console

This message is automatically generated.

> Typo in hbase.hconnection.meta.lookup.threads.core parameter
> ------------------------------------------------------------
>
>                 Key: HBASE-13518
>                 URL: https://issues.apache.org/jira/browse/HBASE-13518
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Enis Soztutar
>            Assignee: Devaraj Das
>             Fix For: 2.0.0, 1.1.0, 1.2.0
>
>         Attachments: 13518-1.txt
>
>
> A possible typo coming from patch in HBASE-13036. 
> I think we want {{hbase.hconnection.meta.lookup.threads.core}}, not {{hbase.hconnection.meta.lookup.threads.max.core}}
to be in line with the regular thread pool configuration. 
> {code}
>             //To start with, threads.max.core threads can hit the meta (including replicas).
>             //After that, requests will get queued up in the passed queue, and only after
>             //the queue is full, a new thread will be started
>             this.metaLookupPool = getThreadPool(
>                conf.getInt("hbase.hconnection.meta.lookup.threads.max", 128),
>                conf.getInt("hbase.hconnection.meta.lookup.threads.max.core", 10),
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message