hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anoop Sam John (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-13502) Deprecate/remove getRowComparator() in TableName
Date Tue, 21 Apr 2015 10:58:58 GMT

    [ https://issues.apache.org/jira/browse/HBASE-13502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14504766#comment-14504766
] 

Anoop Sam John commented on HBASE-13502:
----------------------------------------

bq.This API will go away so that TableName will not have any comparator
Just say deprecated without any replacement

{code}
private KVComparator getRowComparator(TableName tableName) {
  if (TableName.META_TABLE_NAME.equals(this)) {
    return KeyValue.META_COMPARATOR;
  }
  return KeyValue.COMPARATOR;
}
{code}
equals(this) -> U compare against this?  I think copy paste issue. U have to compare against
tableName
In MetaCache  still we use TableName#getRowComparator()?  It can changed to use the new private
API.
import org.apache.hadoop.hbase.KeyValue;
Unused?

> Deprecate/remove getRowComparator() in TableName
> ------------------------------------------------
>
>                 Key: HBASE-13502
>                 URL: https://issues.apache.org/jira/browse/HBASE-13502
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: ramkrishna.s.vasudevan
>             Fix For: 2.0.0
>
>         Attachments: HBASE-13502.patch, HBASE-13502_1.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message