hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-13502) Deprecate/remove getRowComparator() in TableName
Date Tue, 21 Apr 2015 00:03:39 GMT

    [ https://issues.apache.org/jira/browse/HBASE-13502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14503993#comment-14503993

stack commented on HBASE-13502:

Ok, if two places then, yeah, sounds like KVComparator is going to be sticking around a while
(if deprecated). HRI having a getComparator makes more sense but it should not be public so,
deprecate here... I think you can set the IA.Private annotation on a method? Could do that
too for these two getComparator calls.

There are only two comparator types (four if you include reverse comparators) and even then,
the comparators only differ in how they compare rows...  The switch is table name (meta and
user table name -- later, if we bring back root, it will be a 3rd dimension on comparators...).
 Would be good to shutdown the places we go when comparator is not plain (i.e. we didn't read
the comparator to use from hfile, etc.)... say have a static or a factory on CellComparator
that took a TableName instance... and use that in place of these methods.

> Deprecate/remove getRowComparator() in TableName
> ------------------------------------------------
>                 Key: HBASE-13502
>                 URL: https://issues.apache.org/jira/browse/HBASE-13502
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: ramkrishna.s.vasudevan
>             Fix For: 2.0.0
>         Attachments: HBASE-13502.patch

This message was sent by Atlassian JIRA

View raw message