hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anoop Sam John (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HBASE-13496) Make Bytes$LexicographicalComparerHolder$UnsafeComparer::compareTo inlineable
Date Tue, 21 Apr 2015 18:30:59 GMT

     [ https://issues.apache.org/jira/browse/HBASE-13496?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel

Anoop Sam John updated HBASE-13496:
    Attachment: OffheapVsOnHeapCompareTest.java

OffheapVsOnHeapCompareTest  is the micro test I was running. Basically I was testing the byte[]
compare vs BB compare both using Unsafe APIs.  As that result not valid in this Jira not saying
abt that.

Then I saw the inlining problem and with the patch I evaluated the onheap compare time
Avg of 25 runs  - For comparing the 2 arrays for 10 million time
With out patch  321814965.3  (nano secs) 
With patch 211087522.8

> Make Bytes$LexicographicalComparerHolder$UnsafeComparer::compareTo inlineable
> -----------------------------------------------------------------------------
>                 Key: HBASE-13496
>                 URL: https://issues.apache.org/jira/browse/HBASE-13496
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Scanners
>            Reporter: Anoop Sam John
>            Assignee: Anoop Sam John
>             Fix For: 2.0.0, 1.2.0
>         Attachments: ByteBufferUtils.java, HBASE-13496.patch, OffheapVsOnHeapCompareTest.java
> While testing with some other perf comparisons I have noticed that the above method (which
is very hot in read path) is not getting inline
> bq.@ 16   org.apache.hadoop.hbase.util.Bytes$LexicographicalComparerHolder$UnsafeComparer::compareTo
(364 bytes)   hot method too big
> We can do minor refactoring to make it inlineable.

This message was sent by Atlassian JIRA

View raw message