hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anoop Sam John (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HBASE-13496) Make Bytes$LexicographicalComparerHolder$UnsafeComparer::compareTo inlineable
Date Tue, 21 Apr 2015 06:26:59 GMT

     [ https://issues.apache.org/jira/browse/HBASE-13496?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Anoop Sam John updated HBASE-13496:
-----------------------------------
    Attachment: HBASE-13496.patch

Pls note the statements movements to other private methods.  Actually we have to reverseBytes
(for littleEndian case) iff we have a non equal case.(Only while compare- so inside the if).
  Not a big deal still avoiding 2 ops.
Also a multiply in loop var is avoided.  

> Make Bytes$LexicographicalComparerHolder$UnsafeComparer::compareTo inlineable
> -----------------------------------------------------------------------------
>
>                 Key: HBASE-13496
>                 URL: https://issues.apache.org/jira/browse/HBASE-13496
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Scanners
>            Reporter: Anoop Sam John
>            Assignee: Anoop Sam John
>             Fix For: 2.0.0, 1.2.0
>
>         Attachments: HBASE-13496.patch
>
>
> While testing with some other perf comparisons I have noticed that the above method (which
is very hot in read path) is not getting inline
> bq.@ 16   org.apache.hadoop.hbase.util.Bytes$LexicographicalComparerHolder$UnsafeComparer::compareTo
(364 bytes)   hot method too big
> We can do minor refactoring to make it inlineable.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message