hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vandana Ayyalasomayajula (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-13463) Quota needs to be updated only in case of successful region merge
Date Wed, 15 Apr 2015 00:28:58 GMT

    [ https://issues.apache.org/jira/browse/HBASE-13463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14495204#comment-14495204
] 

Vandana Ayyalasomayajula commented on HBASE-13463:
--------------------------------------------------

[~tedyu] -- The idea of updating quota only on successful merge sounds good, as I think concurrent
merge operations would be rare unlike splits. 

looking at the v2 patch, 

{quote}
if (code == TransitionCode.MERGED && org.apache.commons.lang.StringUtils.isEmpty(errorMsg))
{
+        try {
+          regionStateListener.onRegionMerged(hri);
+        } catch (IOException exp) {
+          errorMsg = StringUtils.stringifyException(exp);
+        }
+      }
{quote}
shouldn't that be under MERGED case rather than MERGE_REVERTED ?

> Quota needs to be updated only in case of successful region merge
> -----------------------------------------------------------------
>
>                 Key: HBASE-13463
>                 URL: https://issues.apache.org/jira/browse/HBASE-13463
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>             Fix For: 1.1.0
>
>         Attachments: 13463-v1.txt, 13463-v2-branch-1.txt
>
>
> During review of HBASE-13438, Vandana pointed out the following:
> in the case of MERGE_REVERTED, the assignment manager is not updating the quota. You
need to add another hook in RegionStateListener class just like split.
> This issue is to fix the above case.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message