hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-13450) Purge RawBytescomparator from the writers and readers after HBASE-10800
Date Wed, 22 Apr 2015 19:33:58 GMT

    [ https://issues.apache.org/jira/browse/HBASE-13450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14507734#comment-14507734
] 

stack commented on HBASE-13450:
-------------------------------

bq. It is upto us pass a byte[] to it. I think it is better this way, right?

Why write anything if comparator is null?

bq. What can we do there?

Deprecate the old and add new method (change the order of the params so you can do override
or come up with new method name).



> Purge RawBytescomparator from the writers and readers after HBASE-10800
> -----------------------------------------------------------------------
>
>                 Key: HBASE-13450
>                 URL: https://issues.apache.org/jira/browse/HBASE-13450
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: ramkrishna.s.vasudevan
>             Fix For: 2.0.0
>
>         Attachments: HBASE-13450.patch, HBASE-13450_2.patch
>
>
> Currently KeyValue.RAW_COMPARATOR is written in the Trailer of the HFiles.  Ideally this
need not be persisted to the trailer of the Hfiles because only the ROW bloom and the meta
index blocks uses this. Currently RAW_COMPARATOR is also of type KVComparator.
> HBASE-10800 would introduce CellComparator and would expect only cells to be compared.
 We cannot have RAW_COMPARATOR a type of CellComparator.  Hence it is better to avoid writing
the RAW_COMPARATOR to the FFT and whereever we need RAW_COMPARATOR we will directly use it
as Bytes.BYTES_RAWCOMPARATOR.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message