hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anoop Sam John (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-13450) Purge RawBytescomparator from the writers and readers for HBASE-10800
Date Fri, 24 Apr 2015 15:09:39 GMT

    [ https://issues.apache.org/jira/browse/HBASE-13450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14511190#comment-14511190
] 

Anoop Sam John commented on HBASE-13450:
----------------------------------------

{code}
comparatorClassName.equals(KeyValue.RAW_COMPARATOR.getClass().getName())
... or if
} else if (comparatorClassName.equals(KeyValue.RAW_COMPARATOR.getLegacyKeyComparatorName()))
{
... at a minimum comment why either of these means we return null else it is a little cryptic
{code}

Actually to the FFT we write the table related comparator. ie. CellComparator or MetaCellComparator.
 So within the FFT we will never get RawBytesComparator or Bytes.BYTES_RAWCOMPARATOR.  This
will come in case of ROW_COL bloom and that we will write/read in CompoundBloomFilter and
related area.  We just use FFT's static methods from Bloom area.   We can avoid that so that
FFT no need to handle the RawBytesComparator.   Can do this clean up later in some other subtask.

> Purge RawBytescomparator from the writers and readers for HBASE-10800
> ---------------------------------------------------------------------
>
>                 Key: HBASE-13450
>                 URL: https://issues.apache.org/jira/browse/HBASE-13450
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: ramkrishna.s.vasudevan
>             Fix For: 2.0.0
>
>         Attachments: HBASE-13450.patch, HBASE-13450_2.patch, HBASE-13450_3.patch, HBASE-13450_4.patch,
HBASE-13450_5.patch
>
>
> Currently KeyValue.RAW_COMPARATOR is written in the Trailer of the HFiles.  Ideally this
need not be persisted to the trailer of the Hfiles because only the ROW bloom and the meta
index blocks uses this. Currently RAW_COMPARATOR is also of type KVComparator.
> HBASE-10800 would introduce CellComparator and would expect only cells to be compared.
 We cannot have RAW_COMPARATOR a type of CellComparator.  Hence it is better to avoid writing
the RAW_COMPARATOR to the FFT and whereever we need RAW_COMPARATOR we will directly use it
as Bytes.BYTES_RAWCOMPARATOR.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message