hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-13450) Purge RawBytescomparator from the writers and readers after HBASE-10800
Date Thu, 23 Apr 2015 20:52:39 GMT

    [ https://issues.apache.org/jira/browse/HBASE-13450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14509775#comment-14509775
] 

Hadoop QA commented on HBASE-13450:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12727664/HBASE-13450_4.patch
  against master branch at commit bcb2a279c49213bf4eb90a7602a01ff5d0810915.
  ATTACHMENT ID: 12727664

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 hadoop versions{color}. The patch compiles with all supported hadoop versions
(2.4.1 2.5.2 2.6.0)

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 protoc{color}.  The applied patch does not increase the total number of
protoc compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

                {color:red}-1 checkstyle{color}.  The applied patch generated 1899 checkstyle
errors (more than the master's current 1898 errors).

    {color:green}+1 findbugs{color}.  The patch does not introduce any  new Findbugs (version
2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines longer than 100

  {color:green}+1 site{color}.  The mvn site goal succeeds with this patch.

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/13787//testReport/
Release Findbugs (version 2.0.3) 	warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13787//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/13787//artifact/patchprocess/checkstyle-aggregate.html

                Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/13787//console

This message is automatically generated.

> Purge RawBytescomparator from the writers and readers after HBASE-10800
> -----------------------------------------------------------------------
>
>                 Key: HBASE-13450
>                 URL: https://issues.apache.org/jira/browse/HBASE-13450
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: ramkrishna.s.vasudevan
>             Fix For: 2.0.0
>
>         Attachments: HBASE-13450.patch, HBASE-13450_2.patch, HBASE-13450_3.patch, HBASE-13450_4.patch
>
>
> Currently KeyValue.RAW_COMPARATOR is written in the Trailer of the HFiles.  Ideally this
need not be persisted to the trailer of the Hfiles because only the ROW bloom and the meta
index blocks uses this. Currently RAW_COMPARATOR is also of type KVComparator.
> HBASE-10800 would introduce CellComparator and would expect only cells to be compared.
 We cannot have RAW_COMPARATOR a type of CellComparator.  Hence it is better to avoid writing
the RAW_COMPARATOR to the FFT and whereever we need RAW_COMPARATOR we will directly use it
as Bytes.BYTES_RAWCOMPARATOR.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message