hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-13431) Move splitStoreFile to SplitTransaction interface to allow creating both reference files in case required
Date Tue, 28 Apr 2015 17:38:06 GMT

    [ https://issues.apache.org/jira/browse/HBASE-13431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14517503#comment-14517503
] 

Hadoop QA commented on HBASE-13431:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12728817/HBASE-13431_v3.patch
  against master branch at commit 94a00bea07b71f2383805e966748e504b406b95d.
  ATTACHMENT ID: 12728817

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 3 new or modified
tests.

    {color:green}+1 hadoop versions{color}. The patch compiles with all supported hadoop versions
(2.4.1 2.5.2 2.6.0)

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 protoc{color}.  The applied patch does not increase the total number of
protoc compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 checkstyle{color}.  The applied patch does not increase the total number
of checkstyle errors

    {color:green}+1 findbugs{color}.  The patch does not introduce any  new Findbugs (version
2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines longer than 100

  {color:green}+1 site{color}.  The mvn site goal succeeds with this patch.

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
                       org.apache.hadoop.hbase.TestJMXListener

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/13865//testReport/
Release Findbugs (version 2.0.3) 	warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13865//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/13865//artifact/patchprocess/checkstyle-aggregate.html

  Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/13865//console

This message is automatically generated.

> Move splitStoreFile to SplitTransaction interface to allow creating both reference files
in case required
> ---------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-13431
>                 URL: https://issues.apache.org/jira/browse/HBASE-13431
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Rajeshbabu Chintaguntla
>            Assignee: Rajeshbabu Chintaguntla
>             Fix For: 2.0.0, 1.1.0
>
>         Attachments: HBASE-13431.patch, HBASE-13431_v2.patch, HBASE-13431_v3.patch
>
>
>  APPROACH #3 at PHOENIX-1734 helps to implement local indexing without much changes in
HBase. For split we need one kernel change to allow creating both top and bottom reference
files for index column family store files even when the split key not in the storefile key
range. 
> The changes helps in this case are  
> 1) pass boolean to HRegionFileSystem#splitStoreFile to allow to skip the storefile key
range check.
> 2) move the splitStoreFile with extra boolean parameter  to the new interface introduced
at HBASE-12975. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message