hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-13427) HStore#addChangedReaderObserver hotspots due to missing hashCode and equals on StoreScanner
Date Mon, 13 Apr 2015 23:15:12 GMT

    [ https://issues.apache.org/jira/browse/HBASE-13427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14493248#comment-14493248
] 

stack commented on HBASE-13427:
-------------------------------

[~jleach] Did you see improvement when you applied your patch?

I tried it in a little test (attached) and with the patch, we slow down. If no hash nor equals,
we'll do Object hash and equals which will be pretty cheap as I read it: http://grepcode.com/file/repository.grepcode.com/java/root/jdk/openjdk/6-b14/java/lang/Object.java#Object.hashCode%28%29
Thanks.

> HStore#addChangedReaderObserver hotspots due to missing hashCode and equals on StoreScanner
> -------------------------------------------------------------------------------------------
>
>                 Key: HBASE-13427
>                 URL: https://issues.apache.org/jira/browse/HBASE-13427
>             Project: HBase
>          Issue Type: Bug
>            Reporter: John Leach
>            Assignee: John Leach
>         Attachments: 13427-v4.txt, HBASE-13427.patch, HBASE-13427_CURLY_BRACES.patch,
HBASE-13427_V3.patch, SetFromMap.add_Runnable.tiff
>
>   Original Estimate: 2h
>          Time Spent: 2h
>  Remaining Estimate: 0h
>
> Please see attached graph...



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message