hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-13421) Reduce the number of object creations introduced by HBASE-11544 in scan RPC hot code paths
Date Wed, 08 Apr 2015 21:44:15 GMT

    [ https://issues.apache.org/jira/browse/HBASE-13421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14486122#comment-14486122
] 

Hudson commented on HBASE-13421:
--------------------------------

FAILURE: Integrated in HBase-TRUNK #6359 (See [https://builds.apache.org/job/HBase-TRUNK/6359/])
HBASE-13421 Reduce the number of object creations introduced by HBASE-11544 in scan RPC hot
code paths (stack: rev 62d47e175c7c36dc2bd6b225d03978cd6303fc59)
* hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/compactions/TestStripeCompactionPolicy.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestMergeTool.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/filter/TestFilter.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestGetClosestAtOrBefore.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/coprocessor/ColumnAggregationEndpoint.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/coprocessor/ColumnAggregationEndpointWithErrors.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionScanner.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/ScannerContext.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/coprocessor/TestCoprocessorInterface.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/coprocessor/ColumnAggregationEndpointNullResponse.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestReplicasClient.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestReversibleScanners.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/KeyValueHeap.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestStoreScanner.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/io/encoding/TestPrefixTree.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/Compactor.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestBlocksScanned.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestKeepDeletes.java
* hbase-examples/src/main/java/org/apache/hadoop/hbase/coprocessor/example/RowCountEndpoint.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/filter/TestMultipleColumnPrefixFilter.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/AccessController.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestAtomicOperation.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/InternalScanner.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestScannerSelectionUsingTTL.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/AggregateImplementation.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestWideScanner.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestMultiColumnScanner.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestDefaultMemStore.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestStripeCompactor.java
* hbase-client/src/main/java/org/apache/hadoop/hbase/client/ClientScanner.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestScanner.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/AccessControlLists.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/HBaseTestCase.java
* hbase-examples/src/main/java/org/apache/hadoop/hbase/coprocessor/example/BulkDeleteEndpoint.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestSeekOptimizations.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionMergeTransaction.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/client/ClientSideRegionScanner.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/NoLimitScannerContext.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/filter/TestColumnPrefixFilter.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestIntraRowPagination.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestWALReplay.java
* hbase-client/src/main/java/org/apache/hadoop/hbase/client/ScannerCallableWithReplicas.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFlusher.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestScannerSelectionUsingKeyRange.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/filter/TestDependentColumnFilter.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/filter/TestInvocationRecordFilter.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestColumnSeeking.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestSplitTransaction.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreScanner.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/coprocessor/TestRegionObserverInterface.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestScanWithBloomError.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/TestPartialResultsFromClientSide.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestMajorCompaction.java


> Reduce the number of object creations introduced by HBASE-11544 in scan RPC hot code
paths
> ------------------------------------------------------------------------------------------
>
>                 Key: HBASE-13421
>                 URL: https://issues.apache.org/jira/browse/HBASE-13421
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Jonathan Lawlor
>            Assignee: Jonathan Lawlor
>             Fix For: 2.0.0, 1.1.0
>
>         Attachments: HBASE-13421-branch-1.patch, HBASE-13421-v1.patch, HBASE-13421-v2.patch,
HBASE-13421-v3.patch
>
>
> HBASE-11544 made NextState the new return type of RegionScanner#nextRaw InternalScanner#next
to allow state information to be passed back from a scanner (it was formerly a boolean indicating
whether or not more values existed). The change in this return type led to an increased amount
of objects being created... In the case that a scan spanned millions of rows, there was the
potential for millions of object to be created.
> This issue looks to reduce the large amount of object creations from potentially many
to at most one per RPC request. 
> Please see the tail of the parent issue for relevant discussion on the design decisions
related to this solution. This sub-task has been filed as it seems more appropriate to address
the fix here rather than as an addendum to the parent.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message