hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matteo Bertozzi (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-13397) Purge duplicate rpc request thread local
Date Fri, 03 Apr 2015 15:59:52 GMT

    [ https://issues.apache.org/jira/browse/HBASE-13397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14394610#comment-14394610
] 

Matteo Bertozzi commented on HBASE-13397:
-----------------------------------------

+1 looks great.

only one question, do you think that isInRequestContext() wasn't not useful? what is the reason
aside that we can just check if the return of RpcServer.xyz() is null?

> Purge duplicate rpc request thread local
> ----------------------------------------
>
>                 Key: HBASE-13397
>                 URL: https://issues.apache.org/jira/browse/HBASE-13397
>             Project: HBase
>          Issue Type: Bug
>          Components: rpc
>            Reporter: stack
>            Assignee: stack
>         Attachments: 13397.txt
>
>
> Serverside, in a few locations, code wants access to RPC context to get user and remote
client address. A thread local makes it so this info is accessible anywhere on the processing
chain.
> Turns out we have this mechanism twice (noticed by our Matteo). This patch purges one
of the thread locals.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message