hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-13396) Cleanup unclosed writers in later writer rolling
Date Wed, 08 Apr 2015 12:47:12 GMT

    [ https://issues.apache.org/jira/browse/HBASE-13396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14485200#comment-14485200
] 

Hadoop QA commented on HBASE-13396:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12723891/HBASE-13396-v2.diff
  against master branch at commit b6756b39c2ff5675f96a6e82dc4d68ec437f01c4.
  ATTACHMENT ID: 12723891

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 hadoop versions{color}. The patch compiles with all supported hadoop versions
(2.4.1 2.5.2 2.6.0)

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 protoc{color}.  The applied patch does not increase the total number of
protoc compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 checkstyle{color}.  The applied patch does not increase the total number
of checkstyle errors

    {color:green}+1 findbugs{color}.  The patch does not introduce any  new Findbugs (version
2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines longer than 100

  {color:green}+1 site{color}.  The mvn site goal succeeds with this patch.

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/13620//testReport/
Release Findbugs (version 2.0.3) 	warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13620//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/13620//artifact/patchprocess/checkstyle-aggregate.html

  Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/13620//console

This message is automatically generated.

> Cleanup unclosed writers in later writer rolling
> ------------------------------------------------
>
>                 Key: HBASE-13396
>                 URL: https://issues.apache.org/jira/browse/HBASE-13396
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Liu Shaohui
>            Assignee: Liu Shaohui
>            Priority: Minor
>             Fix For: 2.0.0
>
>         Attachments: HBASE-13396-v1.diff, HBASE-13396-v2.diff
>
>
> Currently, the default value of hbase.regionserver.logroll.errors.tolerated is 2, which
means regionserver can tolerate two continuous failures of closing writers at most. Temporary
problems of network or namenode may cause those failures. After those failures, the hdfs clients
in RS may continue to renew the lease of the hlog of the writer and the namenode will not
help to recover the lease of this hlog. So the last block of this hlog will be RBW(replica
being written) state until the regionserver is down. Blocks in this state will block the datanode
decommission and other operations in HDFS.
> So I think we need a mechanism to clean up those unclosed writers afterwards. A simple
solution is to record those unclosed writers and attempt to close these writers until success.
> Discussions and suggestions are welcomed~ Thanks



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message