hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ramkrishna.s.vasudevan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-13387) Add ServerCell an extension to Cell
Date Fri, 10 Apr 2015 09:06:12 GMT

    [ https://issues.apache.org/jira/browse/HBASE-13387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14489212#comment-14489212
] 

ramkrishna.s.vasudevan commented on HBASE-13387:
------------------------------------------------

I was saying about the new APIs in BufferedCell particularly the new ones to access the BB
position.  Previously we only had one offset API and one length API.  Now we will have one
offset API for array based cells and another API for the offset in BB.  This is what I was
saying.  Not the concept of BufferedCell/ServerCell.  

bq. Yes, if a cell implementation takes the wrong path, it should blowup and throw an exception
You mean throw an exception if array() based APIS are accessed for that Cell when it is a
DBB backed one?

I agree with the instanceof check. And doing the DBB aware comparator is going to be a follow-on
work where it will add more clear read path than all these instanceof checks.

bq. Caching this stuff is secondary I'd say, an implementation detail as Anoop Sam John called
it earlier.
Yes.  In our initial patches we tried to pass on the offsets/lengths if they were available
with us to the  compare methods to avoid parsing them again.  Just wanted to say we have to
do that now if we go with pure cell based APIs in the read paths.

> Add ServerCell an extension to Cell
> -----------------------------------
>
>                 Key: HBASE-13387
>                 URL: https://issues.apache.org/jira/browse/HBASE-13387
>             Project: HBase
>          Issue Type: Sub-task
>          Components: regionserver, Scanners
>            Reporter: Anoop Sam John
>            Assignee: Anoop Sam John
>         Attachments: WIP_HBASE-13387_V2.patch, WIP_ServerCell.patch
>
>
> This came in btw the discussion abt the parent Jira and recently Stack added as a comment
on the E2E patch on the parent Jira.
> The idea is to add a new Interface 'ServerCell'  in which we can add new buffer based
getter APIs, hasArray API etc.  We will keep this interface @InterfaceAudience.Private
> Also we have to change the timestamp and seqId on Cells in server side. We have added
new interfaces SettableSequenceId, SettableTimestamp for this. Now if we can add a ServerCell
we can add the setter APIs there.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message