hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-13387) Add ServerCell an extension to Cell
Date Thu, 09 Apr 2015 16:56:12 GMT

    [ https://issues.apache.org/jira/browse/HBASE-13387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14487662#comment-14487662
] 

stack commented on HBASE-13387:
-------------------------------

[~ram_krish]
bq. I agree with the Filter changes - but there is one place in here, the compareFilters.


Yes. But lets get the overall approach worked out first and then worry about particular details.

bq.  If instanceOf check is not going to cost us more then hasArray would not be needed at
all but we may have traces of instanceOf every where, right?  Atleast in the CellUtil classes.

Having the instanceof checks confined to CellUtil only is not 'everywhere'. It would be a
containment that is a massive improvement over what is going on at the moment in this patch
but also over in the 14-pager Cell/DBB patch.

Let me look at new patch lads.



> Add ServerCell an extension to Cell
> -----------------------------------
>
>                 Key: HBASE-13387
>                 URL: https://issues.apache.org/jira/browse/HBASE-13387
>             Project: HBase
>          Issue Type: Sub-task
>          Components: regionserver, Scanners
>            Reporter: Anoop Sam John
>            Assignee: Anoop Sam John
>         Attachments: WIP_HBASE-13387_V2.patch, WIP_ServerCell.patch
>
>
> This came in btw the discussion abt the parent Jira and recently Stack added as a comment
on the E2E patch on the parent Jira.
> The idea is to add a new Interface 'ServerCell'  in which we can add new buffer based
getter APIs, hasArray API etc.  We will keep this interface @InterfaceAudience.Private
> Also we have to change the timestamp and seqId on Cells in server side. We have added
new interfaces SettableSequenceId, SettableTimestamp for this. Now if we can add a ServerCell
we can add the setter APIs there.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message