hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mikhail Antonov (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-13375) Provide HBase superuser higher priority over other users in the RPC handling
Date Sat, 04 Apr 2015 07:58:33 GMT

    [ https://issues.apache.org/jira/browse/HBASE-13375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14395619#comment-14395619
] 

Mikhail Antonov commented on HBASE-13375:
-----------------------------------------

Thanks for taking a look!

I think groups are never null (rather empty list), and remoteUgi is never null as far as I
saw, but for some tests it's just convenient to be able to pass nulls without having to think
about mocks, plus having additional NPE check doesn't hurt I think :) I can remove these checks
if you think they're really unnecessary here.

I'm thinking to move the call to VisibilityUtil to constructor and have these 2 lists as fields,
as that seems relatively hot codepath.

The problem is that TestHBaseFsck failure is genuine, I'll debug it, so cancelled the patch.
Will look more into that tomorrow.



> Provide HBase superuser higher priority over other users in the RPC handling
> ----------------------------------------------------------------------------
>
>                 Key: HBASE-13375
>                 URL: https://issues.apache.org/jira/browse/HBASE-13375
>             Project: HBase
>          Issue Type: Improvement
>          Components: rpc
>            Reporter: Devaraj Das
>            Assignee: Mikhail Antonov
>             Fix For: 1.1.0
>
>         Attachments: HBASE-13375-v0.patch
>
>
> HBASE-13351 annotates Master RPCs so that RegionServer RPCs are treated with a higher
priority compared to user RPCs (and they are handled by a separate set of handlers, etc.).
It may be good to stretch this to users too - hbase superuser (configured via hbase.superuser)
gets higher priority over other users in the RPC handling. That way the superuser can always
perform administrative operations on the cluster even if all the normal priority handlers
are occupied (for example, we had a situation where all the master's handlers were tied up
with many simultaneous createTable RPC calls from multiple users and the master wasn't able
to perform any operations initiated by the admin). (Discussed this some with [~enis] and [~elserj]).
> Does this make sense to others?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message