hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars Hofhansl (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-13373) Squash HFileReaderV3 together with HFileReaderV2 and AbstractHFileReader; ditto for Scanners and BlockReader, etc.
Date Tue, 07 Apr 2015 00:54:12 GMT

    [ https://issues.apache.org/jira/browse/HBASE-13373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14482333#comment-14482333
] 

Lars Hofhansl commented on HBASE-13373:
---------------------------------------

Abstract, V1, V2, and V3 made adding new HFileReaders easy. What if we wanted to add a HFile
V4? ... Maybe we just need to squash that in like you squashed v2 and v3.

Nice simplification. Belated +1 (although I cannot convince myself that everything works exactly
the way it worked before... I trust you :) )

> Squash HFileReaderV3 together with HFileReaderV2 and AbstractHFileReader; ditto for Scanners
and BlockReader, etc.
> ------------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-13373
>                 URL: https://issues.apache.org/jira/browse/HBASE-13373
>             Project: HBase
>          Issue Type: Task
>            Reporter: stack
>            Assignee: stack
>             Fix For: 2.0.0
>
>         Attachments: 0001-HBASE-13373-Squash-HFileReaderV3-together-with-HFile.patch,
13373.txt, 13373.v3.txt, 13373.v3.txt, 13373.v5.txt, 13373.v6.txt, 13373.v6.txt, 13373.v6.txt,
13373.v6.txt, 13373.v6.txt, 13373.wip.txt
>
>
> Profiling I actually ran into case where complaint that could not inline because:
> MaxInlineLevel maximum number of nested calls that are inlined 9 intx
> i.e. method was more than 9 levels deep.
> The HFileReaderV? with Abstracts is not needed anymore now we are into the clear with
V3 enabled since hbase 1.0.0; we can have just an Interface and an implementation.  If we
need to support a new hfile type, can hopefully do it in a backward compatible way now we
have Cell Interface, etc.
> Squashing all this stuff together actually makes it easier figuring what is going on
when reading code. I can also get rid of a bunch of duplication too.
> Attached is a WIP. Doesn't fully compile yet but you get the idea.
> I'll keep on unless objection. Will try it against data written with old classes as soon
as I have something working. I don't believe we write classnames into our data.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message