hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-13373) Squash HFileReaderV3 together with HFileReaderV2 and AbstractHFileReader; ditto for Scanners and BlockReader, etc.
Date Mon, 06 Apr 2015 18:44:13 GMT

    [ https://issues.apache.org/jira/browse/HBASE-13373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14481602#comment-14481602
] 

stack commented on HBASE-13373:
-------------------------------

Here is exception I get when patch applied to branch-1:

{code}
	... 3 more
Caused by: org.apache.hadoop.hbase.io.hfile.CorruptHFileException: Problem reading HFile Trailer
from file hdfs://localhost:60932/user/stack/test-data/7a7e1f35-8b1c-4f74-bc51-ca5d8697ca53/data/hbase/meta/1588230740/info/a75a20537bba41fd8d602917a08ca937
	at org.apache.hadoop.hbase.io.hfile.HFile.pickReaderVersion(HFile.java:496)
	at org.apache.hadoop.hbase.io.hfile.HFile.createReader(HFile.java:525)
	at org.apache.hadoop.hbase.regionserver.StoreFile$Reader.<init>(StoreFile.java:1042)
	at org.apache.hadoop.hbase.regionserver.StoreFileInfo.open(StoreFileInfo.java:251)
	at org.apache.hadoop.hbase.regionserver.StoreFile.open(StoreFile.java:374)
	at org.apache.hadoop.hbase.regionserver.StoreFile.createReader(StoreFile.java:471)
	at org.apache.hadoop.hbase.regionserver.HStore.createStoreFileAndReader(HStore.java:660)
	at org.apache.hadoop.hbase.regionserver.HStore.access$8(HStore.java:655)
	at org.apache.hadoop.hbase.regionserver.HStore$1.call(HStore.java:530)
	at org.apache.hadoop.hbase.regionserver.HStore$1.call(HStore.java:1)
	... 6 more
Caused by: java.lang.IllegalArgumentException: Invalid HFile version: major=2, minor=0: expected
at least major=2 and minor=3
	at org.apache.hadoop.hbase.io.hfile.HFileReaderImpl.checkFileVersion(HFileReaderImpl.java:295)
	at org.apache.hadoop.hbase.io.hfile.HFileReaderImpl.<init>(HFileReaderImpl.java:183)
	at org.apache.hadoop.hbase.io.hfile.HFile.pickReaderVersion(HFile.java:486)
{code}

> Squash HFileReaderV3 together with HFileReaderV2 and AbstractHFileReader; ditto for Scanners
and BlockReader, etc.
> ------------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-13373
>                 URL: https://issues.apache.org/jira/browse/HBASE-13373
>             Project: HBase
>          Issue Type: Task
>            Reporter: stack
>            Assignee: stack
>             Fix For: 2.0.0
>
>         Attachments: 0001-HBASE-13373-Squash-HFileReaderV3-together-with-HFile.patch,
13373.txt, 13373.v3.txt, 13373.v3.txt, 13373.v5.txt, 13373.v6.txt, 13373.v6.txt, 13373.v6.txt,
13373.v6.txt, 13373.v6.txt, 13373.wip.txt
>
>
> Profiling I actually ran into case where complaint that could not inline because:
> MaxInlineLevel maximum number of nested calls that are inlined 9 intx
> i.e. method was more than 9 levels deep.
> The HFileReaderV? with Abstracts is not needed anymore now we are into the clear with
V3 enabled since hbase 1.0.0; we can have just an Interface and an implementation.  If we
need to support a new hfile type, can hopefully do it in a backward compatible way now we
have Cell Interface, etc.
> Squashing all this stuff together actually makes it easier figuring what is going on
when reading code. I can also get rid of a bunch of duplication too.
> Attached is a WIP. Doesn't fully compile yet but you get the idea.
> I'll keep on unless objection. Will try it against data written with old classes as soon
as I have something working. I don't believe we write classnames into our data.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message