hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-13362) Set max result size from client only (like scanner caching).
Date Thu, 09 Apr 2015 05:52:13 GMT

    [ https://issues.apache.org/jira/browse/HBASE-13362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14486761#comment-14486761

Hadoop QA commented on HBASE-13362:

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  against master branch at commit e2a90a71143f480621ccd935a0b9477d7ee4016f.
  ATTACHMENT ID: 12724121

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 hadoop versions{color}. The patch compiles with all supported hadoop versions
(2.4.1 2.5.2 2.6.0)

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 protoc{color}.  The applied patch does not increase the total number of
protoc compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 checkstyle{color}.  The applied patch does not increase the total number
of checkstyle errors

    {color:green}+1 findbugs{color}.  The patch does not introduce any  new Findbugs (version
2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines longer than 100

  {color:green}+1 site{color}.  The mvn site goal succeeds with this patch.

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/13636//testReport/
Release Findbugs (version 2.0.3) 	warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13636//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/13636//artifact/patchprocess/checkstyle-aggregate.html

  Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/13636//console

This message is automatically generated.

> Set max result size from client only (like scanner caching).
> ------------------------------------------------------------
>                 Key: HBASE-13362
>                 URL: https://issues.apache.org/jira/browse/HBASE-13362
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Lars Hofhansl
>            Assignee: Lars Hofhansl
>             Fix For: 2.0.0, 1.0.1, 1.1.0, 0.98.12
>         Attachments: 13362-0.98.txt, 13362-master-v2.txt, 13362-master.txt
> With the recent problems we've been seeing client/server result size mismatch, I was
thinking: Why was this not a problem with scanner caching?
> There are two reasons:
> # number of rows is easy to calculate (and we did it correctly)
> # caching is only controlled from the client, never set on the server alone
> We did fix both #1 and #2 in HBASE-13262.
> Still, I'd like to discuss the following:
> * default the client sent max result size to 2mb
> * remove any server only result sizing
> * continue to use hbase.client.scanner.max.result.size but enforce it via the client
only (as the name implies anyway).
> Comments? Concerns?

This message was sent by Atlassian JIRA

View raw message