hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Josh Elser (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-13351) Annotate internal MasterRpcServices methods with admin priority
Date Wed, 15 Apr 2015 00:44:02 GMT

    [ https://issues.apache.org/jira/browse/HBASE-13351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14495460#comment-14495460
] 

Josh Elser commented on HBASE-13351:
------------------------------------

It should.

{panel:title=TableStateManager.java}
{code}
  @Nullable
  protected TableState readMetaState(TableName tableName) throws IOException {
    if (tableName.equals(TableName.META_TABLE_NAME))
      return new TableState(tableName, TableState.State.ENABLED);
    return MetaTableAccessor.getTableState(master.getConnection(), tableName);
  }
{code}
{panel}

When we read the state of a table from meta, we should be reusing the Master's cached connection
(which has the opportunity to give us the short-circuit variant).

The question I have, is are we actually getting a ShortCircuit connection when we think we
should be

{panel:title=ConnectionUtils.java}
{code}
      @Override
      public ClientService.BlockingInterface getClient(
          ServerName sn) throws IOException {
        return serverName.equals(sn) ? client : super.getClient(sn);
      }
{code}
{panel}

My current hunch is that we're failing that conditional for one reason or another. Will dig
into this next.

> Annotate internal MasterRpcServices methods with admin priority
> ---------------------------------------------------------------
>
>                 Key: HBASE-13351
>                 URL: https://issues.apache.org/jira/browse/HBASE-13351
>             Project: HBase
>          Issue Type: Improvement
>          Components: master
>            Reporter: Josh Elser
>            Assignee: Josh Elser
>             Fix For: 2.0.0, 1.1.0
>
>         Attachments: HBASE-13351-v1.patch, HBASE-13351-v2.patch, HBASE-13351-v3.patch,
HBASE-13351.patch
>
>
> HBASE-12071, among other things, introduced annotating RPC methods to give certain methods
priority over others. Namely, this helps ensure that client requests cannot starve out internal
RPC between master and regionserver.
> Similarly, we can do the same thing for Master RPC methods that are invoked by RS's.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message