hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mikhail Antonov (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-13351) Annotate internal MasterRpcServices methods with admin priority
Date Thu, 02 Apr 2015 07:15:53 GMT

    [ https://issues.apache.org/jira/browse/HBASE-13351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14392275#comment-14392275
] 

Mikhail Antonov commented on HBASE-13351:
-----------------------------------------

Good thing! few notes:

 - QosPriority now needs to have javadoc IMO
 - at first I was a bit surprised why do we need that change in HMaster - since tests which
don't need cluster generally don't start master either, but looks like that's a bit special
case here
 - do you think these RPCs should go with admin QoS, or we should have something with lower
QoS (say, 50?) If HRS couldn't report to master in time about something, that might be less
urgent compared to admin ops? on the other hand, avoiding having to add one more thread pool
for this class of methods would be either.

> Annotate internal MasterRpcServices methods with admin priority
> ---------------------------------------------------------------
>
>                 Key: HBASE-13351
>                 URL: https://issues.apache.org/jira/browse/HBASE-13351
>             Project: HBase
>          Issue Type: Improvement
>          Components: master
>            Reporter: Josh Elser
>            Assignee: Josh Elser
>             Fix For: 2.0.0, 1.1.0
>
>         Attachments: HBASE-13351-v1.patch, HBASE-13351.patch
>
>
> HBASE-12071, among other things, introduced annotating RPC methods to give certain methods
priority over others. Namely, this helps ensure that client requests cannot starve out internal
RPC between master and regionserver.
> Similarly, we can do the same thing for Master RPC methods that are invoked by RS's.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message