hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-13350) Add a debug-warn if we fail HTD checks even if table.sanity.checks is false
Date Wed, 15 Apr 2015 07:10:00 GMT

    [ https://issues.apache.org/jira/browse/HBASE-13350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14495781#comment-14495781
] 

Hadoop QA commented on HBASE-13350:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12725476/HBASE-13350.patch
  against master branch at commit 4f151444b58ae85b93f76254961358932e0ffb9b.
  ATTACHMENT ID: 12725476

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 4 new or modified
tests.

    {color:green}+1 hadoop versions{color}. The patch compiles with all supported hadoop versions
(2.4.1 2.5.2 2.6.0)

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 protoc{color}.  The applied patch does not increase the total number of
protoc compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

                {color:red}-1 checkstyle{color}.  The applied patch generated 1911 checkstyle
errors (more than the master's current 1910 errors).

    {color:green}+1 findbugs{color}.  The patch does not introduce any  new Findbugs (version
2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines longer than 100

  {color:green}+1 site{color}.  The mvn site goal succeeds with this patch.

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/13706//testReport/
Release Findbugs (version 2.0.3) 	warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13706//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/13706//artifact/patchprocess/checkstyle-aggregate.html

                Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/13706//console

This message is automatically generated.

> Add a debug-warn if we fail HTD checks even if table.sanity.checks is false
> ---------------------------------------------------------------------------
>
>                 Key: HBASE-13350
>                 URL: https://issues.apache.org/jira/browse/HBASE-13350
>             Project: HBase
>          Issue Type: Improvement
>          Components: master, Operability
>    Affects Versions: 2.0.0, 1.1.0
>            Reporter: Matteo Bertozzi
>            Priority: Trivial
>         Attachments: HBASE-13350.patch
>
>
> HBASE-10591 introduced Sanity checks for table configuration in createTable.
> In HMaster.sanityCheckTableDescriptor() we skip all the checks if "hbase.table.sanity.checks"
is true.
> for debuggability we should log a warn when table.sanity.checks is false.
> there are nice checks in there like no families, maxFileSize limit, flush size limit,
compression/encryption codec available, TTL, block size, ... that will help debug what is
going on



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message